[MemorySSA] Don't create phi nodes in fixupDefs() (#156021) The general flow when inserting MemoryDefs is: * Insert the def and set it's defining access (may insert phis) * Insert IDF phis * Update defining access for defs after the new one (fixupDefs) * Rename uses if requested fixupDefs() uses getPreviousDef() which can create new MemoryPHIs, but for which we're not going to insert IDF phis, so the required dominance property may not hold. I believe this is a leftover from a time before the "Insert IDF phis" step existed. Now that step should already ensure that all necessary MemoryPhis have been inserted, and we only need to update them. The fixupDefs() implementation was also returning after updating a single access, which is not right. Fixes https://github.com/llvm/llvm-project/issues/47875. Fixes https://github.com/llvm/llvm-project/issues/117157. Fixes https://github.com/llvm/llvm-project/issues/152998. Fixes https://github.com/llvm/llvm-project/issues/155161. Fixes https://github.com/llvm/llvm-project/issues/155184.
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.