tree 89c579c2efc4193df9f085a93a246e87b486b3c4
parent aa054c681059257d371857945c08840f69f68379
author Andrew Rogers <andrurogerz@gmail.com> 1747238052 -0700
committer GitHub <noreply@github.com> 1747238052 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoJLykCRC1aQ7uu5UhlAAAzLMQAGIsSY0JRZAjQczAMBI5vc3X
 LIjDFhCqyqH9HMLRj9qV0qLi/Cu5vAboFzqKo/qiG/D6I83Ttsy9oXZhhazJ9lQh
 Vmf1PvMF+udTIqVs7shdDAcMFCgc4TTl2+0zGam8OohXLUV1t4SBvih2fWQk548x
 YWG7wP6nkYK9S6OqtiKnEqYUMRJtgzPqYIS+Y0y6QTOO/q/6v+5qTQwCJaR2OScC
 rFfYpX1NQNLyqntywNRYQ1yyUe84f5JW4gyXprOCq2ZP7jxfKpEbj/qmqdkh9K+e
 QNEIPLYBGkeVKaT4IcEASyT0MdG/MHCxVqE/KOHs30c2fgUSry6f8oKy+BOpKZQ0
 sPjucSkAmQoI6g580r1kqwG2VmdPaIQ+iSlx1NW3D/2ahs6sVCqTotWTus5n0daM
 ciG01lO/b2wXQ1JIj+mN89tVP4TkrFUQftL0LkcPlDvleI2x+FjjTJPyIFic9Sn7
 grMpfQC+30Eu+5niUIXwYb6P2QC0sE51NKanqKD/VIR906eyo4cc8H8Z1P++Jlh+
 aNSK35jeie/G7K0CAr77G7pQQSo1FK+AAm9uG+5k2bibvD4VDl9cvVUaYljDr3bJ
 CFE/249czxpCUEz/xq5SbElsUCeJaeSRDBGPtG0Pwrgr6W6ZU3bUvInVGu0cS4qF
 5f4Yye3tHUdLwv2uPM2a
 =cOZ6
 -----END PGP SIGNATURE-----
 

[llvm] properly guard dump methods in Support lib classes (#139804)

## Purpose
Add proper preprocessor guards for all `dump()` methods in the LLVM
support library. This change ensures these methods are not part of the
public ABI for release builds.

## Overview
* Annotates all `dump` methods in Support and ADT source with the
`LLVM_DUMP_METHOD` macro.
* Conditionally includes all `dump` method definitions in Support and
ADT source so they are only present on debug/assert builds and when
`LLVM_ENABLE_DUMP` is explicitly defined.

NOTE: For many of these `dump` methods, the implementation was already
properly guarded but the declaration in the header file was not.

## Background
This issue was raised in comments on #136629. I am addressing it as a
separate change since it is independent from the changes being made in
that PR.

According to [this
documentation](https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Support/Compiler.h#L637),
`dump` methods should be annotated with `LLVM_DUMP_METHOD` and
conditionally included as follows:
```
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
  LLVM_DUMP_METHOD void dump() const;
#endif
```

## Validation
* Local release build succeeds.
* CI