tree f38d775876ab6d36c07446c88750c1805febed41
parent 33e5305c598be9b4f57feba330b963c2142d15cc
author Maksim Levental <maksim.levental@gmail.com> 1744475560 -0400
committer GitHub <noreply@github.com> 1744475560 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJn+pWoCRC1aQ7uu5UhlAAATpAQAIkNQUXaQxqKvfAFq+8mjO0Q
 EWpXb3Z4B3p7N+HaTNRpXbdsLqhwLkY7+C3PTMsx7GEhCqz5gT2mpW6gnV2weKXQ
 s3sdxzPn//uLxCAKvU8eCCYHDY/Hemzelfi9ibyAOcQMjruaF4hDcsaMjgHXpdtW
 RBiLEkm8V1x+9OsF/1gboeEHPqC+OrMk8VAgtykbHbyvlyDWsFY3+sBkZE3vSj5w
 WETib7MiYW5RI1HokISHZaAkMtFwoU7FFApf0+IENBbNtkvfGZ1700LiaIrQs3eH
 bYWB7tKe8MAtUk7dSx05H7eKGgAekbCDtyli/ouS9Eu5xNO46PR0Cav+JGVe+M+Y
 MCaIafExGnWPnTonKI2g91rt0Le0i04DI6tFnn6zzIOu3yblRkDqYVFDzI64KL6Q
 bqWju5aBnbVsmiUvU10q4DsSMAyUJbheloxp2udrqj4EhHdm6URRpWHHCrTqKVfq
 nISUT1RIn2baTba36hrEJ8uHUBg2wymWFceDZX9sEDPt2+f93DwyYZwlpymkT4CJ
 3wKVAHGgOTOhDlGpZD/rF6XKgfmOD31dmFdV0CooYs/o4oKxuE78PB6haQcpALyE
 9BYRf/zOF2BIEbnHz5lTgpGv3GdZpw8q3eM0w19uryM8ZhNBPPMqgu55advEb6Pi
 BiMQB3wVYkQbqwkIGghY
 =UJug
 -----END PGP SIGNATURE-----
 

[mlir][SMT] restore custom builder for forall/exists (#135470)

This reverts commit 54e70ac7650f1c22f687937d1a082e4152f97b22 which
itself fixed an [asan
leak](https://lab.llvm.org/buildbot/#/builders/55/builds/9761) from the
original upstreaming commit. The leak was due to op allocations not
being `free`ed.

~~The necessary change was to explicitly `->destroy()` the ops at the
end of the tests. I believe this is because the rewriter used in the
tests doesn't actually insert them into a module and so without an
explicit `->destroy()` no bookkeeping process is able to take care of
them.~~

The necessary change was to use `OwningOpRef` which calls `op->erase()`
in its [own
destructor](https://github.com/makslevental/llvm-project/blob/89cfae41ecc043f8c47be4dea4b7c740d4f950b3/mlir/include/mlir/IR/OwningOpRef.h#L39).