[lldb][windows] do not attach to a PseudoConsole if it is not opened (#177934) # Summary This patch ensures lldb will not try to read from a PseudoConsole if it has not been opened. # Original issue https://github.com/llvm/llvm-project/pull/168729 introduces support for the Windows ConPTY in `lldb-dap`. This caused a regression in `lldb` which was not caught by our tests: https://github.com/llvm/llvm-project/issues/175652. This patch fixes https://github.com/llvm/llvm-project/issues/175652. `lldb_private::ProcessLauncherWindows::LaunchProcess` connects the debuggee to a PseudoConsole only if: ```cpp if (hPC != INVALID_HANDLE_VALUE && launch_info.GetNumFileActions() == 0 && launch_info.GetFlags().Test(lldb::eLaunchFlagLaunchInTTY)) ``` lldb needs to check the same condition in `lldb_private::PlatformWindows::DebugProcess` to ensure that it does not read from a PseudoConsole which has not been opened. # Side effect This patch reverts what https://github.com/llvm/llvm-project/pull/168729 did by adding ConPTY support. https://github.com/llvm/llvm-project/pull/175812 is the proper fix, however it's causing tests failures which we can't reliably reproduce at desk. Given https://github.com/llvm/llvm-project/pull/168729 breaks `22.x` lldb, it's better to revert the change ahead of the release of `22.x` rather than pushing for the proper fix.
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.