tree cf82fdfb2e962b647d46c8bd3406171d2b887924
parent a35f940b876a09211f3e68dd25d00271b7195145
author anjenner <161845516+anjenner@users.noreply.github.com> 1745311515 +0100
committer GitHub <noreply@github.com> 1745311515 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoB1cbCRC1aQ7uu5UhlAAA2sEQAGokUwNPVsuIeZyDfW/RYF9W
 uyfvQOpR35/4HvjbeUdok9iYITKKkge0MlJRH8gBCAZJK3DkD0TFb0lZk327ieGN
 Goow23f7W+biq9KZTA7hUwiTz+vq1YGIIplXHjdNbQ+do7u888JQJ4Eqtab4ItIG
 J17TMt7/Qaqv4QDK5Tu/2eUrUxgQ6qmxuUvbLJqcPpL2omCki1kBEbn1fs9PKpju
 t0tPg0VHZaqSpz7X1Ig3Gk3SSV4tpq18YwEDS+E0r56zJYg0QXrLwvdTinS7ihpy
 5aOfCx2fi4agfDHeP/4JwgIerqaPZkGjw+8nuUEZDlqQlFwTYunQfNOG/gDQv8Tp
 vs9waOTcy3gEiBFnD7sp3p9uzyNkjVzoi+RpgGQGX+k0S26dS69o05nL9X/E46gY
 Tvb2G3jFKV7+PIccmqj9Zo+XWp9SQD6CwaeaKG9cTludWXHDyZVlqnt7UFDNIYyq
 76elYORrh9/434M6Tcudh9U2M5OBvWme/d0J+O+2mhbHU7ZQ8UHG5TQPkJnMpR5H
 xa6GauH+CQl3q0PwU2z/M2HCFPhUHKS61hu4mHktN4u1LWS4KagwtsDKxKcSQ0TM
 z+b9YACncL7UI8B4nLQVBhEmeD6gX1SIadzRRLFUUpqDjchmDMHjbN3r8mXp4vpG
 2ukmQDw7ERRZljWFsXIM
 =lSoU
 -----END PGP SIGNATURE-----
 

Modify the localCache API to require an explicit commit on CachedFile… (#136121)

…Stream.

CachedFileStream has previously performed the commit step in its
destructor, but this means its only recourse for error handling is
report_fatal_error. Modify this to add an explicit commit() method, and
call this in the appropriate places with appropriate error handling for
the location.

Currently the destructor of CacheStream gives an assert failure in Debug
builds if commit() was not called. This will help track down any
remaining uses of the API that assume the old destructior behaviour. In
Release builds we fall back to the previous behaviour and call
report_fatal_error if the commit fails.

This is version 2 of this PR, superseding reverted PR
https://github.com/llvm/llvm-project/pull/115331 . I have incorporated a
change to the testcase to make it more reliable on Windows, as well as
two follow-up changes
(https://github.com/llvm/llvm-project/commit/df79000896101acc9b8d7435e59f767b36c00ac8
and
https://github.com/llvm/llvm-project/commit/b0baa1d8bd68a2ce2f7c5f2b62333e410e9122a1)
that were also reverted when 115331 was reverted.

---------

Co-authored-by: Augie Fackler <augie@google.com>
Co-authored-by: Vitaly Buka <vitalybuka@google.com>