tree c6205f8584f1f2a1ca5ec3c7fa35c8c717cf2855
parent ef70cc9d1ac69125f38910d4c66388536f49f4dc
author Roman Lebedev <lebedev.ri@gmail.com> 1593873588 +0300
committer Roman Lebedev <lebedev.ri@gmail.com> 1593875524 +0300
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEEjkF6151RK40WXe2HCDw+u0oWieAFAl8AnEUACgkQCDw+u0oW
 ieC1AQ//cIvJPnaT4yCwnjX0yCN9TXVFsuKtPQnDQ9DbBb3sR0BtK66AvpcsG0QH
 Kl2Uuvo4MbPeIpJteYjlIdCf2m2YxjiuRrRPkudynsP6WNoSpWZHxk0g+52aWbTv
 O4TKXYnmFMnPPE3JhSgtS9WrzKta/6pxwLxsiSfwarjQByj/ng6DAIHXR6c5z0pr
 DVt3fLyqa/xIKAXxvqBa2wVZPbz5yav/rqRAZXVCFrDzZMsRi8u8U8eyrInsozo8
 XNMS3CPUN0HkYspgGiXLqx+XawJn37EzagvFjsYFAeSnbeD8awHHzwk/jsR/O5FI
 72fAMDCF6QCGVCaIZboCwz2B0SoMipoQnpO5BmGUjXFY8SAc0z4maQE9YlpEZlY+
 l662RBBLQWE46plNap3q52ENZvCb0+F60db1FPdCTl9rAGkqVeZTPe9GvHBhMmjN
 K3Nl94q5V4fqoTSIlxy65d1t9vufPNj4qP4Iml2NJ1T1rO3uje407J7fGZwlzw1i
 Aew4mMf4Z9tuk43dJg6e6Gxs/cBXROrF/EOFwYAf53rDTvhUgdhWLyNFcRa03l9Y
 9eNGzCZUQ3fNKHIkZSxi6Hfg5qQvOQ4seL5wAy+ujVpwnv85zhDyznB5GTd91fsZ
 Wx+Eje8ydT2psZc/oQ0on/mor5koj+qLtINVU6+awyMYuZHUmWY=
 =ITj1
 -----END PGP SIGNATURE-----

[InstCombine] Always try to invert non-canonical predicate of an icmp

Summary:
The actual transform i was going after was:
https://rise4fun.com/Alive/Tp9H
```
Name: zz
Pre: isPowerOf2(C0) && isPowerOf2(C1) && C1 == C0
%t0 = and i8 %x, C0
%r = icmp eq i8 %t0, C1
  =>
%t = icmp eq i8 %t0, 0
%r = xor i1 %t, -1

Name: zz
Pre: isPowerOf2(C0)
%t0 = and i8 %x, C0
%r = icmp ne i8 %t0, 0
  =>
%t = icmp eq i8 %t0, 0
%r = xor i1 %t, -1
```
but as it can be seen from the current tests, we already canonicalize most of it,
and we are only missing handling multi-use non-canonical icmp predicates.

If we have both `!=0` and `==0`, even though we can CSE them,
we end up being stuck with them. We should canonicalize to the `==0`.

I believe this is one of the cleanup steps i'll need after `-scalarizer`
if i end up proceeding with my WIP alloca promotion helper pass.

Reviewers: spatel, jdoerfert, nikic

Reviewed By: nikic

Subscribers: zzheng, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D83139