tree fc4ffffbae35c6ca8997988174c21b83a8142955
parent 28293ea023c1aeeed3bff0e2d06feacc9bc365cd
author Sergei Barannikov <barannikov88@gmail.com> 1745670340 +0300
committer GitHub <noreply@github.com> 1745670340 +0300
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoDNDECRC1aQ7uu5UhlAAAHAAQACfo2zrCs6P4hIaIfMbh5zbe
 IqK07AxA1NFB/XkVtfe6NYTE9skXTAzKHWt4w/Ied3cM+Sm4jLPM2OllZMdEzBWz
 IOOd6Nm9v8twpxBVguPH6PLVQD0iHSA0c+vAOX8NQ4+mJBkoQKpNO1k5Q6l/c6/d
 z1RjVe16a+HQohZKc1HvkQc2oSGTizZ+lVIUltpOMRk2sfdBGErEa7CdquFvlUu0
 vzDP9RVLtPf0kIyGyuenC6EWj2PG0KQRSCwo2QIPrExwf6WluRYHnOr5Yk80PhCQ
 bBjatWQUL7aunUh8SBsqiG3Sg4kiFcJY2FM5vg2Wfh823cofFlugnjf1U9PRBe0g
 AwBzhtdn/OvXwfJ9hpbP+JtFO/nYx+iTORPQQSTCwja9hxWjNzFF4BqhEFD4XyCx
 I2EZkhMepZ+2vtu8D0Ru3x2ZtyO8AAGM4h4Xogzyv/tVBv+UI0PyaZ2YDGCcudFA
 +ivrc+Y1z6vE/i5VxEFYGr2bkeQVG2F4aGaGUOQLQgS5KM/9uC7/YY+H0f3+YjIk
 fZ2YBf1i3pNXRxDeW4YWD9gFxcSYMIp58Lyp0+AEdCDyfqxIGuurhgTgJKXkwcsB
 /ZreuDXOePdsVr2gwMSB0lyqyovBWkKDbsVjcbu738CZ0nLILMW0VaZHcGqhqmL2
 YRwWhqe91HmLz16XvUVX
 =ks3O
 -----END PGP SIGNATURE-----
 

[TTI] Simplify implementation (NFCI) (#136674)

Replace "concept based polymorphism" with simpler PImpl idiom.

This pursues two goals:
* Enforce static type checking. Previously, target implementations hid
base class methods and type checking was impossible. Now that they
override the methods, the compiler will complain on mismatched
signatures.
* Make the code easier to navigate. Previously, if you asked your
favorite LSP server to show a method (e.g. `getInstructionCost()`), it
would show you methods from `TTI`, `TTI::Concept`, `TTI::Model`,
`TTIImplBase`, and target overrides. Now it is two less :)

There are three commits to hopefully simplify the review.

The first commit removes `TTI::Model`. This is done by deriving
`TargetTransformInfoImplBase` from `TTI::Concept`. This is possible
because they implement the same set of interfaces with identical
signatures.

The first commit makes `TargetTransformImplBase` polymorphic, which
means all derived classes should `override` its methods. This is done in
second commit to make the first one smaller. It appeared infeasible to
extract this into a separate PR because the first commit landed
separately would result in tons of `-Woverloaded-virtual` warnings (and
break `-Werror` builds).

The third commit eliminates `TTI::Concept` by merging it with the only
derived class `TargetTransformImplBase`. This commit could be extracted
into a separate PR, but it touches the same lines in
`TargetTransformInfoImpl.h` (removes `override` added by the second
commit and adds `virtual`), so I thought it may make sense to land these
two commits together.

Pull Request: https://github.com/llvm/llvm-project/pull/136674