[SandboxIR] Implement missing ConstantVector member functions (#131390)
This patch implements get(), getSplat(), getSplatValue() and getType(),
mirroring LLVM IR.
diff --git a/llvm/include/llvm/SandboxIR/Constant.h b/llvm/include/llvm/SandboxIR/Constant.h
index 17f55e9..c4841e0 100644
--- a/llvm/include/llvm/SandboxIR/Constant.h
+++ b/llvm/include/llvm/SandboxIR/Constant.h
@@ -424,7 +424,19 @@
friend class Context; // For constructor.
public:
- // TODO: Missing functions: getSplat(), getType(), getSplatValue(), get().
+ static Constant *get(ArrayRef<Constant *> V);
+ /// Return a ConstantVector with the specified constant in each element.
+ /// Note that this might not return an instance of ConstantVector
+ static Constant *getSplat(ElementCount EC, Constant *Elt);
+ /// Specialize the getType() method to always return a FixedVectorType,
+ /// which reduces the amount of casting needed in parts of the compiler.
+ inline FixedVectorType *getType() const {
+ return cast<FixedVectorType>(Value::getType());
+ }
+ /// If all elements of the vector constant have the same value, return that
+ /// value. Otherwise, return nullptr. Ignore poison elements by setting
+ /// AllowPoison to true.
+ Constant *getSplatValue(bool AllowPoison = false) const;
/// For isa/dyn_cast.
static bool classof(const Value *From) {
diff --git a/llvm/include/llvm/SandboxIR/Value.h b/llvm/include/llvm/SandboxIR/Value.h
index 2e91b96..5089787 100644
--- a/llvm/include/llvm/SandboxIR/Value.h
+++ b/llvm/include/llvm/SandboxIR/Value.h
@@ -145,6 +145,7 @@
friend class CmpInst; // For getting `Val`.
friend class ConstantArray; // For `Val`.
friend class ConstantStruct; // For `Val`.
+ friend class ConstantVector; // For `Val`.
friend class ConstantAggregateZero; // For `Val`.
friend class ConstantPointerNull; // For `Val`.
friend class UndefValue; // For `Val`.
diff --git a/llvm/lib/SandboxIR/Constant.cpp b/llvm/lib/SandboxIR/Constant.cpp
index 3e13c93..e2b0472 100644
--- a/llvm/lib/SandboxIR/Constant.cpp
+++ b/llvm/lib/SandboxIR/Constant.cpp
@@ -174,6 +174,28 @@
return StructType::get(Ctx, EltTypes, Packed);
}
+Constant *ConstantVector::get(ArrayRef<Constant *> V) {
+ assert(!V.empty() && "Expected non-empty V!");
+ auto &Ctx = V[0]->getContext();
+ SmallVector<llvm::Constant *, 8> LLVMV;
+ LLVMV.reserve(V.size());
+ for (auto *Elm : V)
+ LLVMV.push_back(cast<llvm::Constant>(Elm->Val));
+ return Ctx.getOrCreateConstant(llvm::ConstantVector::get(LLVMV));
+}
+
+Constant *ConstantVector::getSplat(ElementCount EC, Constant *Elt) {
+ auto *LLVMElt = cast<llvm::Constant>(Elt->Val);
+ auto &Ctx = Elt->getContext();
+ return Ctx.getOrCreateConstant(llvm::ConstantVector::getSplat(EC, LLVMElt));
+}
+
+Constant *ConstantVector::getSplatValue(bool AllowPoison) const {
+ auto *LLVMSplatValue = cast_or_null<llvm::Constant>(
+ cast<llvm::ConstantVector>(Val)->getSplatValue(AllowPoison));
+ return LLVMSplatValue ? Ctx.getOrCreateConstant(LLVMSplatValue) : nullptr;
+}
+
ConstantAggregateZero *ConstantAggregateZero::get(Type *Ty) {
auto *LLVMC = llvm::ConstantAggregateZero::get(Ty->LLVMTy);
return cast<ConstantAggregateZero>(
diff --git a/llvm/unittests/SandboxIR/SandboxIRTest.cpp b/llvm/unittests/SandboxIR/SandboxIRTest.cpp
index 088264e..bdc9c2c 100644
--- a/llvm/unittests/SandboxIR/SandboxIRTest.cpp
+++ b/llvm/unittests/SandboxIR/SandboxIRTest.cpp
@@ -524,6 +524,18 @@
auto *StructTy2Packed = sandboxir::ConstantStruct::getTypeForElements(
Ctx, {ZeroI42, OneI42}, /*Packed=*/true);
EXPECT_EQ(StructTy2Packed, StructTyPacked);
+
+ // Check ConstantVector::get().
+ auto *NewCV = sandboxir::ConstantVector::get({ZeroI42, OneI42});
+ EXPECT_EQ(NewCV, Vector);
+ // Check ConstantVector::getSplat(), getType().
+ auto *SplatRaw =
+ sandboxir::ConstantVector::getSplat(ElementCount::getFixed(2), OneI42);
+ auto *Splat = cast<sandboxir::ConstantVector>(SplatRaw);
+ EXPECT_EQ(Splat->getType()->getNumElements(), 2u);
+ EXPECT_THAT(Splat->operands(), testing::ElementsAre(OneI42, OneI42));
+ // Check ConstantVector::getSplatValue().
+ EXPECT_EQ(Splat->getSplatValue(), OneI42);
}
TEST_F(SandboxIRTest, ConstantAggregateZero) {
