tree 5f0572d9225e51cb8179f187648439e8d7a12e85
parent dc41571cd8af5a4de87412c64666899ec3f2b971
author David Spickett <david.spickett@linaro.org> 1755074909 +0100
committer GitHub <noreply@github.com> 1755074909 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJonFFdCRC1aQ7uu5UhlAAAqPQQAHhFFjFLU4HuFUnBZv+HTPmf
 nYQrwVQzhKWTigPZRa5921dW4xdZcwmoalalbMdvHc+JFHcCN5i/gDgWMwFM6+uX
 cJ0YYLe7jQ0djTtBeM41v0adMe6WPYdRglRiUWpqMDCPu/1yRMU22YArQsyLU8Qf
 dHbcLj5S5cuMQsGIyprg4v2rY620jHZrzWo3gOnfPQ6zghg6e12drfOP8FEjTvx4
 KqPAowr4YSuX2PtxBr95GvD6H2//KiLdi64ubN5ebGBtAazymm6YULoI6iU3NxYr
 eMsAJpByPEcZA/d9R1XNdYaV5gx/LsisredO4PigEmtEVB5gJevDV747GUqmzc/b
 TQMswlQfODTAgHE1rvsnH+6qxl2jylBsc9GVfkG4nXe3fYdPXJgCSNCMKBiY1gVh
 1GFBu+LNrFD9JCkXh4kVICR9Ykxd2CwJb4QtDz/X0PaljM0TZlyC4qjAl1r2as8B
 MpTm1aqHK+4Gwv/xjKj3fDg2xPEQQKNuwMyWvaHc79yj/KPLVK67hEoT9xsiVXJX
 Z2AYOSLUEQ6u9RABV+B7w3NsAq7Db8O1Fjbc5EIpiwRy3gIDnaC3th+LLRm5iiWC
 dh6+h0WssoCwxvJpbx65/MVRcebzdZsni7sR/9a8mN7801O6cs+Mp/g3LjgZBepZ
 mzjZg7hlnhuov63PE38+
 =x0Ka
 -----END PGP SIGNATURE-----
 

[lldb] Convert registers values into target endian for expressions (#148836)

Relates to https://github.com/llvm/llvm-project/issues/135707

Where it was reported that reading the PC using "register read" had
different results to an expression "$pc".

This was happening because registers are treated in lldb as pure
"values" that don't really have an endian. We have to store them
somewhere on the host of course, so the endian becomes host endian.

When you want to use a register as a value in an expression you're
pretending that it's a variable in memory. In target memory. Therefore
we must convert the register value to that endian before use.

The test I have added is based on the one used for XML register flags.
Where I fake an AArch64 little endian and an s390x big endian target. I
set up the data in such a way the pc value should print the same for
both, either with register read or an expression.

I considered just adding a live process test that checks the two are the
same but with on one doing cross endian testing, I doubt it would have
ever caught this bug.

Simulating this means most of the time, little endian hosts will test
little to little and little to big. In the minority of cases with a big
endian host, they'll check the reverse. Covering all the combinations.