tree 96b39d6e575b2c896a11c667417fb767852566d6
parent fd7f69bfe7b694d22cd74058faa90b8a93a6d949
author Jesse Schwartzentruber <truber@mozilla.com> 1755623621 -0400
committer GitHub <noreply@github.com> 1755623621 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJopLDFCRC1aQ7uu5UhlAAAYTwQALIhwB+zVfvUsvudUWaIigJn
 0rGGz8d73/M6zWnRjWCjnGCIszAe7Ld5uIsPINIydnxat6PEdaE52MIw3Tn/F4T2
 HCfo16pYg7wrhHl3wffYgQSSvtoQbbJYTFZhycrTdZOodoK5oRuwfMRkjxhq5w9r
 nSLLIgVTTb8aRh/bIc7lbXnhTtP/PNmijzIBLWg8zi3KxXtDF1wSF2UsSMVno6U1
 N3uhP9GoVwbfCq/FcZlRP3uX139O87hVRE0lZGIxz02rqUWtxBcXzkBtPZXjvXVr
 aqbMMCgESMsNfuaHrNjaOgFYCg2+GVIxuvoZVNsi4+duKvERDNniDGjReRaqL1hR
 x4kiNXd72vYvx8iAojdKA4+QblpVW7N7W+Goe8wQhHwluOaV2DjPwWKSoaPijx9X
 JV3IKo9hhZxPYoF/snDRiF6sryxcrI6zWtPAkfvj/W/duoUnQbA7lOlOMhmRxG73
 Y5EYlgr+SQK0uXmrk+jGFcCoR8hYc871Y0ByejjZQRdVPOZlOp8nE4AtaLNHu/B2
 AMnx5GRg0vpClm6p9kFC4E4jERhCtW6+pVote7pYWVY2QKugjMbJLUiVwyBN6Krq
 h5NqZFf7y1hldCn4xwqtHerftDm5+6dTFrm/yKFT+v4uQEDGVh8WoTXI03+i7+Cj
 KCsGPkE5SBJrZ92gQo2o
 =iULw
 -----END PGP SIGNATURE-----
 

[compiler-rt] Fix frame numbering for unparsable frames. (#148278)

This can happen when JIT code is run, and we can't symbolize those
frames, but they should remain numbered in the stack. An example
spidermonkey trace:

```
    #0 0x564ac90fb80f  (/builds/worker/dist/bin/js+0x240e80f) (BuildId: 5d053c76aad4cfbd08259f8832e7ac78bbeeab58)
    #1 0x564ac9223a64  (/builds/worker/dist/bin/js+0x2536a64) (BuildId: 5d053c76aad4cfbd08259f8832e7ac78bbeeab58)
    #2 0x564ac922316f  (/builds/worker/dist/bin/js+0x253616f) (BuildId: 5d053c76aad4cfbd08259f8832e7ac78bbeeab58)
    #3 0x564ac9eac032  (/builds/worker/dist/bin/js+0x31bf032) (BuildId: 5d053c76aad4cfbd08259f8832e7ac78bbeeab58)
    #4 0x0dec477ca22e  (<unknown module>)
```

Without this change, the following symbolization is output:

```
    #0 0x55a6d72f980f in MOZ_CrashSequence /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:248:3
    #1 0x55a6d72f980f in Crash(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/src/shell/js.cpp:4223:5
    #2 0x55a6d7421a64 in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:501:13
    #3 0x55a6d742116f in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:597:12
    #4 0x55a6d80aa032 in js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICFallbackStub*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jit/BaselineIC.cpp:1705:10
    #4 0x2c803bd8f22e  (<unknown module>)
```

The last frame has a duplicate number. With this change the numbering is
correct:

```
    #0 0x5620c58ec80f in MOZ_CrashSequence /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:248:3
    #1 0x5620c58ec80f in Crash(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/src/shell/js.cpp:4223:5
    #2 0x5620c5a14a64 in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:501:13
    #3 0x5620c5a1416f in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:597:12
    #4 0x5620c669d032 in js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICFallbackStub*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jit/BaselineIC.cpp:1705:10
    #5 0x349f24c7022e  (<unknown module>)
```