tree db546647b4b504a935e897a5b97ad9116dd0d494
parent ee312fc182510bc6dda072f51956a9e76f6e2638
author Victor Chernyakin <chernyakin.victor.j@outlook.com> 1757345401 -0700
committer GitHub <noreply@github.com> 1757345401 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJovvZ6CRC1aQ7uu5UhlAAAk3YQACxERd65VhFbkOh8kl2xK3FZ
 Xp2gd2yxmTrofAYuWXeU1SbpoQAhbNOsHqfLtdc5VKuVdgcEUrcgqSe59AwtB0QP
 AIJUQcLlLsnbl2Rh3pIlfJ9VKPHmm30df4XGg1USiri0jHho8LB1JciTl07GPHRq
 19vQBJ8m1uipWevc0fZNMJWmFl7810z+kQKymxp9QIteqLVYdtWp0aYxUgr38mOU
 k1c4HHzv06jOMNn7rSTbFQJOJVC3GhB3lPSgeYLx4j6ybthaA2xauiwkbJKrmZhz
 O3fPa9/ya2rA2RpF8OHpL7LgtxpK+9xVb/X5ujwA6w4LY1iYsk43lF6Iz/RbNznG
 /3XwK/L3wr4HPT1CVfkt2knK85VKY2nN1N9PtJ/JZYrycNnY0RKEq3Dvi70EcCbV
 gXWjcNJh8wQ1+caildA1GuDC40JSbnQKVIBiwITysnrBqNYNbLPur3Al2E5ZW2US
 CcX/A0hFWic+E/mFIbPcB6RGBvzBUtvWYd+llBjPjWlnT3pB0C62fJ8FsPnPnSna
 dplbXKcxQl+MdKKR997NylbaQfi+OIQMirC9eJDvln5do8Y5pObXA52/36acGgJN
 a7dgSnDWW5GZmLYMHDgfYItU4WdmCuzbw5n1ehKmXZafZ5Z4JGO2UPdHKWSSPJNG
 9YrFU4TH/6LS+j6n3xgK
 =wYpq
 -----END PGP SIGNATURE-----
 

[clang-tidy][NFC] Do less unnecessary work in `NoLintDirectiveHandler` (#147553)

Summary:
- `NoLintBlockToken` is too big: it stores a whole `NoLintToken` inside
itself, when all it needs from that `NoLintToken` is its `Pos` and
`ChecksGlob`.
- `formNoLintBlocks` builds up a vector of unmatched tokens, which are
later transformed into errors. We can skip the middle step and make
`formNoLintBlocks` create errors directly.
- In `generateCache`, the line `Cache[FileName] = ...;`
default-constructs a cache entry only to immediately overwrite it. We
can avoid that by using `Cache.try_emplace(FileName, ...);` instead.
- `NoLintToken`'s constructor takes `const std::optional<std::string>&`
when all it needs is `const std::optional<StringRef>&`. This forces its
caller, `getNoLints`, to create temporary strings.
- `NoLintToken::checks` returns `std::optional<std::string>` by value,
creating unnecessary copies in `formNoLintBlocks`.