commit ab77a70a7441f52150694bddadcabd11f8d61533
author Aviad Cohen <aviadcohen7@gmail.com> Sat May 31 04:14:28 2025 +0300
committer GitHub <noreply@github.com> Fri May 30 18:14:28 2025 -0700
tree 9f473636c065e1120ab30be6f227f19e06b6f4c4
parent 0996bfc663e870fb3a7820beccded553f4d5fc37

Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags (#142210)

The check was meant to check `IgnoreProperties` works as expected but
operated on the wrong operation.

Co-authored-by: Aviad Cohen <aviad.cohen2@mobileye.com>

mlir/unittests/IR/OperationSupportTest.cpp

diff --git a/mlir/unittests/IR/OperationSupportTest.cpp b/mlir/unittests/IR/OperationSupportTest.cpp
index b185128..18ee9d7 100644
--- a/mlir/unittests/IR/OperationSupportTest.cpp
+++ b/mlir/unittests/IR/OperationSupportTest.cpp
@@ -350,10 +350,10 @@
   auto req2 = b.getI32IntegerAttr(60);
   Operation *opWithProperty2 = b.create<test::OpAttrMatch1>(
       b.getUnknownLoc(), req2, nullptr, nullptr, req2);
-  EXPECT_NE(getHash(op1, OperationEquivalence::None),
-            getHash(op2, OperationEquivalence::None));
   EXPECT_EQ(getHash(opWithProperty1, OperationEquivalence::IgnoreProperties),
             getHash(opWithProperty2, OperationEquivalence::IgnoreProperties));
+  EXPECT_NE(getHash(opWithProperty1, OperationEquivalence::None),
+            getHash(opWithProperty2, OperationEquivalence::None));
   opWithProperty1->destroy();
   opWithProperty2->destroy();
 }