tree 57eb7d1faf45034893c0141a5239e15252eef233
parent de6f7504c83d8a61e78372ea4da92414f95efa8f
author Andy Kaylor <akaylor@nvidia.com> 1756324447 -0700
committer GitHub <noreply@github.com> 1756324447 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJor2JfCRC1aQ7uu5UhlAAAxmIQAAHUY/ZbXCoHg/LU/ESwGaVC
 cb2DKdkMVzePKyAiK5DiEMvaQTUC0VccM/B7wghV1jhJJAb+v8vqOf9jXTQ9TPRD
 FPvVcBhFnxL/e35hu3Yhmte3bcmLJYkdjidRJ46imyXQYuwUqxSSKVPH6lGdlFCA
 j6m0Rvq4Zdtn8utvXH02Qb7aQbqwZ1sVihVlydr7R0f1EcG1Q65N113cbXBHMXlE
 UHlXPI5vFl/Cf8DDRD+2s66ROOmcV3AD7OA3NxXDeNAxu2Q8WfbbhX8QOcPZNWsi
 tV0bdF8lobHf8PqKPzFK2b3+3M/31hdS0vpbl4NNOth1gkV+VF9jo1DVe73IMlJD
 NBvCqPjC3+GT77UKxTDwV/WesbeXjFnv/XJ8r5M0Oc/le8JDijfGH2kZLzTSZ3kK
 gn6ePJ6PLejaRgz5N2buLwyNbaSDqaaAn/vGdzukHLbQKSitBrd3Wfx9Nuf6/K8x
 eZxhY0RkyVfoJpq5yzDUqs6wEiC7ZSTVEHXnQTLmjqYR17Zrk/D08maRIgDLu36t
 j6PadkzXbTss+Jx1Kzzkw8JfZZWdLOWflPOqIAHhjSyM41ehd/cU95ERQf3snrY9
 agt2GpgxdyK8f6ZnVe0dKXubVUPqWesZGBtO04AgbcIptuvebLZlXswk3mZCMK6r
 OC2vm0/8IzHyseHaAoXY
 =Y7vG
 -----END PGP SIGNATURE-----
 

[CIR][NFC] Add errors for unhandled AggExprEmitter visitors (#155469)

There are a lot of required handlers in AggExprEmitter that are
currently missing. Because the ASTVisitor has fallbacks, this means we
just silently ignore whatever expressions are not explicitly handled.
This patch adds handlers where we know they will be needed and just
issues a diagnostic.

This exposed failures in a few tests. In one case, we should have
handled constant initialization earlier, which would have avoided going
to the AggExprEmitter at all. I added a stub with a missing feature
marker to allow that case to work as it had. Another test required us to
ignore cast expressions that should be ignored, so I partially
implemented the cast visitor. Finally, there's a case where the test was
just accepting a bad result. I changed that case to XFAIL until it can
be properly fixed.