)]}'
{
  "commit": "9d7177a2d7e63f90effea848e897cbf96690d154",
  "tree": "1d1f193572d1eb2b96431e97892e1214214dae9a",
  "parents": [
    "71e623d878ecbf66324e15b3a3b2e983e2d7942a"
  ],
  "author": {
    "name": "Renaud Kauffmann",
    "email": "rkauffmann@nvidia.com",
    "time": "Tue Feb 11 10:47:38 2025 -0800"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Tue Feb 11 10:47:38 2025 -0800"
  },
  "message": "[flang][NFCI] Stop tracking memory source after a load in a more explicit manner. (#126156)\n\nTypically, we do not track memory sources after a load because of the\r\ndynamic nature of the load and the fact that the alias analysis is a\r\nsimple static analysis.\r\n\r\nHowever, the code is written in a way that makes it seem like we are\r\ncontinuing to track memory but in reality we are only doing so when we\r\nknow that the tracked memory is a leaf and therefore when there will\r\nonly be one more iteration through the switch statement. In other words,\r\nwe are iterating one more time, to gather data about a box, anticipating\r\nthat this will be the last time. This is a hack that helped avoid\r\ncut-and-paste from other case statements but gives the wrong impression\r\nabout the intention of the code and makes it confusing.\r\n\r\nTo make it clear that there is no more tracking, we gather all the\r\nnecessary data from the memref of the load, in the case statement for\r\nthe load, and exit the loop. I am also limiting this data gathering for\r\nthe case when we load a box reference while we were actually following\r\ndata, as tests have shows, is the only case when we need it for. Other\r\ncases will be handled conservatively, but this can change in the future,\r\non a case-by-case basis.\r\n\r\n---------\r\n\r\nCo-authored-by: Joel E. Denny \u003cjdenny.ornl@gmail.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "01f3a0326db216e875b32501772a6208f0fd767d",
      "old_mode": 33188,
      "old_path": "flang/lib/Optimizer/Analysis/AliasAnalysis.cpp",
      "new_id": "5827d1c3c529ed25c3611530f84d16decf90b4cd",
      "new_mode": 33188,
      "new_path": "flang/lib/Optimizer/Analysis/AliasAnalysis.cpp"
    },
    {
      "type": "modify",
      "old_id": "ca97c5900281d6478123be7c8d364b4e28e6d043",
      "old_mode": 33188,
      "old_path": "flang/test/Analysis/AliasAnalysis/alias-analysis-2.fir",
      "new_id": "24cfaf6ed7ecc91e9671560f4c68320af5ed0f49",
      "new_mode": 33188,
      "new_path": "flang/test/Analysis/AliasAnalysis/alias-analysis-2.fir"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "8e88b508d56e3725c4f78387d8ae86a04db7aca9",
      "new_mode": 33188,
      "new_path": "flang/test/Analysis/AliasAnalysis/alias-analysis-target.fir"
    }
  ]
}