tree 0c7106860dca4a889d9826b7ce4a3921dfa1705c
parent f22e7b5a6f9b2fcc968bda860253e3b4b363aada
author Chuanqi Xu <yedeng.yd@linux.alibaba.com> 1783587117 +0800
committer GitHub <noreply@github.com> 1783587117 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJqT2EtCRC1aQ7uu5UhlAAAq7EQABz+vs8hZHTh+0ZpKiT/+07B
 3h3aWV5Jg3tfcyslSZbsJUrBDiyo2GdhUE82RxOMuX1NWbDjSgf7Xp6HlQJXuW/6
 bib8IBKoMu0E/9nqzzw+x2CEUCATNKVK60TOlCen15Pd/5LzjhtYm+yueE46lTSx
 7ThuupeC9hdAXrQGEVfa1HJzcAyZgFvw0GOTy/QC1TTBWVxxROBODpXOYIRAiPbI
 iyFZyyvQe5IoNjLJIYxoneT7Wy21FfGR17zhZeixDFLuNo43WmLMgLtXgw52U88d
 QtTNUqzqJKHNOqhZL83bCQg9V+9Q+NjyZ0O1b7VP8GT8WL3JfaSPfuOm6gCH50JG
 tvh4Q7LCa1AuCMpfa95sOvnsnAw9Wv0xYeY1mGgmjpc/PAUw7jJLKXJRQ+PJP+jq
 c9SAv7/ILsN7zC5EC4Sm1apip3uORL2VtGvdAL7GEA5icgQqbpdUCwxRANDFA8yE
 /NalrnNR7f0p+v60KZhcndtTn8ycaiuArCdGWLXb1n9Fr37S6ZONWvtixqbcYAjL
 xzoZ6vBYsLrl2SvkDMEunvVYLgLKXHVWT0Bgfz7P8XEyNG/CwfR8GqgpEbJNGRB3
 FB3h/w4GCoDBa6X9cNlMHiXAgnyv/1CdLiAZ0j5L0of7G8JYNDth5ktMItUdvgBz
 Hb9k/xG+5uTyuECooJNX
 =aKOB
 -----END PGP SIGNATURE-----
 

[clang] [serialization] Step into UsingShadowDecl when find existing decl (#208393)

Close https://github.com/llvm/llvm-project/issues/207581

The root cause of the problem is that：enum constant decl, for which its
parent is not enum class, is special. They can be accessed directly
without access its parent. When modules join the game, it becomes more
complex. As for members in other entities like class, we can assume the
member is accessable if their parent are accesable. But it is a
different story for enums. See
https://github.com/llvm/llvm-project/issues/131058 for the whole story
of the backrgound.

Then we didn't write enum constant decl to the lookup table of its
parent of parent in the ASTWriter. So that if other consumer in Sema
wants to access them, they have to get it by entities like exported
using decls. However, the problem is, in ASTReader, when we merge decls,
we use noload_lookup to find existing decls. And the absense of unnamed
enum decl in the parent of its parent's lookup table makes the merge
fails. For enum constant decl in named enum, they will still have a name
lookup table. So we will merge them somehow. But for enum constants in
unnamed enum, they were removed from the only lookup table so the merge
fails. This is the whole story of the current issue.

To fix this, when we merge decls, we step into the UsingShadowDecl to
find the real decls. This is fine as we never merge decls with different
kinds. We can even call this a tiny optimization.