commit 9b8dbe2c8d8f9ba31db572d218ed00dcb283eaba
author lntue <lntue@google.com> Mon Oct 14 19:33:22 2024 -0400
committer GitHub <noreply@github.com> Mon Oct 14 19:33:22 2024 -0400
tree e4def1e289f670ecb5cbc7f214a4bd569ed6af88
parent 627746581b8fde4143533937130f420bbbdf9ddf

[libc][complex] Fix compiler warnings for usage of complex.h header. (#112282)

libc/cmake/modules/LLVMLibCCompileOptionRules.cmake

diff --git a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
index e3a111c..3846c59 100644
--- a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
+++ b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
@@ -153,8 +153,13 @@
     list(APPEND compile_options "-Wconversion")
     list(APPEND compile_options "-Wno-sign-conversion")
     # Silence this warning because _Complex is a part of C99.
-    list(APPEND compile_options "-Wno-c99-extensions")
-    list(APPEND compile_options "-Wno-pedantic")
+    if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+      list(APPEND compile_options "-fext-numeric-literals")
+      list(APPEND compile_options "-Wno-pedantic")
+    else()
+      list(APPEND compile_options "-Wno-c99-extensions")
+      list(APPEND compile_options "-Wno-gnu-imaginary-constant")
+    endif()
     list(APPEND compile_options "-Wimplicit-fallthrough")
     list(APPEND compile_options "-Wwrite-strings")
     list(APPEND compile_options "-Wextra-semi")
@@ -210,7 +215,7 @@
       list(APPEND compile_options "-fno-exceptions")
       list(APPEND compile_options "-fno-unwind-tables")
       list(APPEND compile_options "-fno-asynchronous-unwind-tables")
-      if(NOT ${c_test})
+      if(NOT c_test)
         list(APPEND compile_options "-fno-rtti")
       endif()
     endif()
@@ -231,8 +236,15 @@
     # list(APPEND compile_options "-Wwrite-strings")
     # list(APPEND compile_options "-Wextra-semi")
     # Silence this warning because _Complex is a part of C99.
-    list(APPEND compile_options "-Wno-c99-extensions")
-    list(APPEND compile_options "-Wno-pedantic")
+    if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+      if(NOT c_test)
+        list(APPEND compile_options "-fext-numeric-literals")
+        list(APPEND compile_options "-Wno-pedantic")
+      endif()
+    else()
+      list(APPEND compile_options "-Wno-c99-extensions")
+      list(APPEND compile_options "-Wno-gnu-imaginary-constant")
+    endif()
     # if(NOT CMAKE_COMPILER_IS_GNUCXX)
     #   list(APPEND compile_options "-Wnewline-eof")
     #   list(APPEND compile_options "-Wnonportable-system-include-path")