tree 6105f223e73711bd22d0ee4cdbf0cdbe1d7b644d
parent 9124e963a3bf73fd7430a17535d638601be5630f
author Peter Collingbourne <peter@pcc.me.uk> 1745868222 -0700
committer GitHub <noreply@github.com> 1745868222 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoD9W+CRC1aQ7uu5UhlAAAqnwQALAwNfQdk5czzIYWRQHlR6gB
 QcD1YFWossnF5S/YlQDK8V5pJX5rJHHkx1GQxhxe6Sa3RsnbK1b3v4rhvrSvH0/d
 a2fFGa6TPrcRC9iKOuX0fYFA9jtvAsk8Pv3hOGaIY+Pnrs1I/R/fzyDiRAhnOeMZ
 JhrWbarYgYVkkkuFHiUxbwOcrUt8Z7J4x3L5GalG3B0Koco/F6iOB3C+8c5eR854
 tc13v4VkAvKyjiYAa+ZKWdQwj5ldLJvTZR503bCl3CQFoNCf9iVNhT19yd95tJK/
 KUo1H04yvtI3np4RxEkayaUuH3CIltEZUT1HtGFMvWtdv2x8aZR5az+VlLjpFxWZ
 KItJ9mDbdWCxZlZuCSbulzZ2ijzYis1/akmiyPrGs5XC9YSNlfVzPBUVGv8X6R5i
 S5KvK+NMeiCX8jEpzrai5O54xPQaGkB9hzmTFE5dbprK63h5ixdpO6Sd1UmYF/Qu
 F0H8+VwC+G3iF8/FR+A0wD3MDH9Ej0aaFGJr4MFkpY5N0h/88Cil67B5kutQeSP2
 EQqQHrdgn82ZPZImwJvnPx0s1hQnPyViFHaQgKE3jmsmwpbMBrQM0A96fbZRSBL/
 +xlpQM70Kn6YTcd4RJez5GPvPKRr1Fr0tEpX3sFkOxtS8OzBLtHcUKpZyL8GG3jz
 cCE82jrdl+7OxLu1upjN
 =DF2X
 -----END PGP SIGNATURE-----
 

Linker: Remove dropTriviallyDeadConstantArrays().

By calling this function after every link, we introduce quadratic
behavior during full LTO links that primarily affects links involving
large numbers of constant arrays, such as the full LTO part of a
ThinLTO link which will involve large numbers of vtable constants.
Removing this call resulted in a 1.3x speedup in the indexing phase
of a large internal Google binary.

This call was originally introduced to reduce memory consumption during
full LTO (see commit dab999d54f39af3ebb6a23e850dbc9742016fac8), but it
doesn't seem to be the case that this helps any more. I ran 3 stage2
links of clang with full LTO and ThinLTO with and without this change
and measured the max RSS. The results were as follows (all in KB):

```
FullLTO before 22362512 22383524 22387456
         after 22383496 22365356 22364352
ThinLTO before  4391404  4478192  4383468
         after  4399220  4363100  4417688
```

As you can see, any max RSS differences are in the noise.

Reviewers: nikic, teresajohnson

Reviewed By: teresajohnson, nikic

Pull Request: https://github.com/llvm/llvm-project/pull/137081