tree 2c10d84ae4ebc7eec8e1e2182561c0b09234b7c8
parent 910220b84fa18ce2cbb2e21dd53b9f3d0ae582a7
author Douglas <Douglas.Gliner@sony.com> 1747402845 -0700
committer GitHub <noreply@github.com> 1747402845 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoJ0BdCRC1aQ7uu5UhlAAACXkQAJgLnqBMZl0+Q2abWupST/8J
 eQfQEd1fCRNp3E2+8QyGVX2Y+jUBRjrMbZSTioEE+a/rhqQEz8jsp6MLeykqw8IG
 O9g2qNEkc7rRBqeYlCGQ5QeExD7SGtL5VGthnF4TqK/GqC/u8nq2N+ezJKqYA+lt
 f4hmLu/782SsQxLl/ihRZmP6QuQIypLdRckBGjMQcKDoPcel4V5TPVtgqMcFiB7H
 wHqPCzmGRtXPRvZFW6X/Jkh7648U73U/oxTUMZgM5+QYarZziDZAerajdaTq/hxX
 SDVj/rPmV0Yn8z/Jn4M1+avur7c55QxBR3a6BPySf9A7MNnbCI3GYJcY8JNVl7FD
 f1OC1/aPdz0NqSPzs8aICtc2EYxmch2NBtinrc1eUpXB70y/xq2IfWr8CwCSbmuU
 YpjFhzYp6ZJRF+jHj3dbnew1yvtveEhk9JiF9Qd+eNu46oTF+W7jIIUsNjzO0MGW
 +OnYoOjgwhmzJUsz3g9jjwTn1c1gDB4ssv1+edu+rE4LwhGyDFO3obZylWGZ/okV
 v16TsJNE8Cd9sxlh9ZdUQQT2CDy6znLBF1e5kB8msJtew8em9So34E9Sd49SbN5C
 4Xr5ircKnFSER4+V3NC/lZfji2dufXzK3IzpcAv6mY0ay87kHxNiZ/iJLN7m9gQD
 ihfb1fDXEQwcfi094YtX
 =Za9H
 -----END PGP SIGNATURE-----
 

[Support] Set `OF_Delete` for `InMemoryBuffer`'s call to `openFileForWrite` under `commit` (#140109)

https://github.com/llvm/llvm-project/pull/134787 unintentionally enabled
`--mmap-output-file` by default under LLD which caused the Windows-only
test `lld\test\ELF\link-open-file.test` to fail. This failure uncovered
what appears to be an inconsistency on Windows between
`createOnDiskBuffer` and `createInMemoryBuffer` with respect to `DELETE`
access for the output file.

The output file created by `createOnDiskBuffer` sets the flag
`OF_Delete` as part of `fs::TempFile::create` while the output file
created by `createInMemoryBuffer` sets `OF_None` under
`InMemoryBuffer::commit`.

The test `lld\test\ELF\link-open-file.test` ensures that if
`FILE_SHARE_DELETE` is _not_ specified for an output file that LLD is
expected to overwrite, LLD should fail. This only happens if: "the file
or device has been opened for delete access" which is only done for
`fs::TempFile::create`.

See
https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew#FILE_SHARE_DELETE.

Therefore, I propose setting `OF_Delete` for `InMemoryBuffer::commit`'s
call to `openFileForWrite` to stay consistent with
`fs::TempFile::create`.