tree a5b00916164a0aa02740910e22e9fee9ebb78264
parent 90a959a8c978671467041c865509a0e1823c5115
author Vitaly Buka <vitalybuka@google.com> 1714195636 -0700
committer GitHub <noreply@github.com> 1714195636 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmLIy0CRC1aQ7uu5UhlAAAScQQACKAXNbPTzDU5yxsVAv+YenA
 sqU11XysR8hXdmLjPIegyHVi5bDVPs9X1AggYKmK/pvjTDOdgQ/6kAIFer5/TEoh
 wUW4NBlOWMQnC7dUcMHLlYLEVZJR4FgGnyn63Q25X4ABd8/KxZjPw6Y02IF4hYsj
 t19UTGkfu9qhUB5N988TzLTBYaboqyn2+MrZATwZFwPAxLPi40m7ik1eiN/MxLHE
 V5l+HlVsrTpocMBwvSSBFiMsGei5BuJfGNpvudr2bZc8jTf+PdsTxIpiiVOczG9g
 GvJAciY4FED4c0Q8YSWY2r736vxr9IivugvmeF1dLaJzccjRCa8gFHwJWTRIuVqM
 DMHGAfSIDKuoHqaTqO40vA7Hi7Fy9fwkAl686bqgctvTyrEb5GVxifZrh9IYK4SI
 rcou8H03VqHWHc0oNNiKSVZH16k2IH5vcx+ffHrXcP64xu1o2uxOWs6f5ZusQ0qg
 WEMZrNn5SDxZmPPB92YLxVpgxKnQOY6g0lOsmDDga+wmlKjPcqCQQkzaeaf921Ol
 5CoOWXBALYm/MnqplM1fW0O5rQVQwWDTDtTKdubx97xE4+lap30ktw3fOj/O+Ip1
 GGdDhWi5jhx6JV4R2X8WjTkVqOIZhyAl+Kkhj1wpw8bIxMZ+oEFdHcs8twLoFdFT
 tha12Ifk3Pmes7gdGzP4
 =ZZFW
 -----END PGP SIGNATURE-----
 

[libcxx] Remove empty ~__no_destroy (#89882)

Primary motivation: is that after #84651 msan will
complain if fields accessed after ~__no_destroy.

My understanding of the https://eel.is/c++draft/basic.life#10
Static object with trivial destruction has program lifetime.
Static object with empty destuctor has implicit lifetime, and
accessing the object after lifetime is UB.

It was UB before #84651, it's just msan ignored union members.

Existing code with unions uses empty destructor, so accessing after
the main() can cause UB.

"placement new" version can have trivial destructor, so there is no end
of lifetime.

Secondary motivation: empty destructor will register __cxa_atexit with
-O0.
https://gcc.godbolt.org/z/hce587b65

We can not remove the destructor with union where
_Tp can have non-trivial destructor.

But we can remove destructor if we use in-place
new instead of union.
https://gcc.godbolt.org/z/Yqxx57eEd - empty even with -O0.

New test fails without the patch on

https://lab.llvm.org/buildbot/#/builders/sanitizer-x86_64-linux-bootstrap-msan