tree 7edc2b685864998a7198ffe32c94f825635290d8
parent cedeb31e6d08b1e1e134478b36dd7ed1ef6221a0
author martinboehme <mboehme@google.com> 1694501009 +0200
committer GitHub <noreply@github.com> 1694501009 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJlAAiRCRBK7hj4Ov3rIwAApGcIAKj9k7HjXOm2wVTAenLeXOXH
 o54aDCnpvMpXChf5Qh5PF67RFpHmKsxZcAmGGymL/SCoh+9J5P7f8lXc43h56e5w
 2zcAXGtdTpPy36uyAhQiSGJOBo+mKanffAVJOcacqEEY6bqT7VAYWjfFzAiC5Jlt
 /bq2pnT/+OszjknuMqJ3eVJ2b7Vfsqec6BMBlntUJ22qW6gcVacOYqUvD5E9L1dQ
 sst3bOmDdexsgt3vVqaqviyeG3R1l4mhiZkR2H9SjuCA+iSwnDV3avVCzKN6hZ0M
 ZUYMo90sLdc3dOs3mbsQD854FsnMnbTizCge0XWV8N5tNnmrvMozLwRRdFG5jFc=
 =G2Sy
 -----END PGP SIGNATURE-----
 

[clang][dataflow] Merge `RecordValue`s with different locations correctly. (#65319)

Now that prvalue expressions map directly to values (see
https://reviews.llvm.org/D158977), it's no longer guaranteed that
`RecordValue`s
associated with the same expression will always have the same storage
location.

In other words, D158977 invalidated the assertion in
`mergeDistinctValues()`.
The newly added test causes this assertion to fail without the other
changes in
the patch.

This patch fixes the issue. However, the real fix will be to eliminate
the
`StorageLocation` from `RecordValue` entirely.