)]}'
{
  "commit": "7a3edbfbcf4acaaabb80e7e5073692690ef920cd",
  "tree": "f58685551f8ea92d88ea90913ae646c12bb388ed",
  "parents": [
    "a4a3c487251eee524c16d6b7b7c3000cdbac6a13"
  ],
  "author": {
    "name": "Charles Zablit",
    "email": "c_zablit@apple.com",
    "time": "Wed Sep 23 11:53:23 2026 +0100"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed Sep 23 11:53:23 2026 +0100"
  },
  "message": "[lldb][Windows] Enable the multithreaded and multiple-debuggers API tests (#224305)\n\n`api/multithreaded` and `api/multiple-debuggers` build a C++ driver\nagainst the SB API. Both were skipped on Windows with `\"clang-cl does\nnot support throw or catch (llvm.org/pr24538)\"`, which is no longer what\nstops them. Two things do: the drivers fail to compile because\n`common.h` and `multi-process-driver.cpp` include `\u003cunistd.h\u003e`\nunconditionally, and once they compile they run on a different CRT than\n`liblldb.dll`: the gnu-style clang driver links\n[`libcmt`](https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/MSVC.cpp)\nunless `-fms-runtime-lib\u003d` is passed, so the driver gets the static CRT\nwhile `liblldb.dll` gets the DLL one.\n\nFixes:\n\n- Include `\u003cdirect.h\u003e` and `\u003cio.h\u003e` instead of `\u003cunistd.h\u003e` on Windows,\nand get the working directory with\n[`_getcwd`](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/getcwd-wgetcwd?view\u003dmsvc-170).\n- `get_working_dir` returns a `std::string` now.\n- `test_stop-hook.cpp` uses `_pipe`/`_fdopen` on Windows, and closes the\npipe streams instead of the descriptors they were opened over, write end\nfirst so the interpreter\u0027s I/O thread sees EOF.\n- Guard the `\u003cunistd.h\u003e` include in `multi-process-driver.cpp`.\n- `buildDriver` passes `-fms-runtime-lib\u003ddll` (`dll_dbg` for a Debug\nbuild) and drops the `libcmt` the driver adds at the link step.\n\n`test_breakpoint_location_callback` stays skipped, for an unrelated\nreason: `BreakpointCreateByName` with `eFunctionNameTypeFull` resolves\nno location in a PDB build, while `eFunctionNameTypeAuto` resolves one.\nTracked in #224303.\n\nrdar://177435499",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6e5f844a7263009758cb3d7348f59925d8279923",
      "old_mode": 33188,
      "old_path": "lldb/packages/Python/lldbsuite/test/lldbtest.py",
      "new_id": "b5cb1ffd292b1cd3876f2af9c8cbffa2c1a4630b",
      "new_mode": 33188,
      "new_path": "lldb/packages/Python/lldbsuite/test/lldbtest.py"
    },
    {
      "type": "modify",
      "old_id": "13c2f5d961a78f28b9f4f60b1074d38f61036485",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py",
      "new_id": "c6010e109c12fd0baf19b2decb5788f27baac228",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py"
    },
    {
      "type": "modify",
      "old_id": "5847dc709a7711f0ceed66be6e3670917cef54a0",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multiple-debuggers/multi-process-driver.cpp",
      "new_id": "30af50ba389c45f333feab900b0d866029e424db",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multiple-debuggers/multi-process-driver.cpp"
    },
    {
      "type": "modify",
      "old_id": "3a3467936a349c0089c8d8856244b26714ba0ce2",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multithreaded/TestMultithreaded.py",
      "new_id": "c306fe9b0af751f854ae1e8bdc2a6db01303c640",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multithreaded/TestMultithreaded.py"
    },
    {
      "type": "modify",
      "old_id": "2ef1cb7c5664dc8088ebf8af543a0f3a9d1b1915",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multithreaded/common.h",
      "new_id": "0df4b771f95500be24c2dfb271166c9bdcbdf3e0",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multithreaded/common.h"
    },
    {
      "type": "modify",
      "old_id": "f4f76c6071fb1cb69dd22fef2978e563d3a68e39",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multithreaded/listener_test.cpp",
      "new_id": "b030bf57b93e922151738844da3214aa9bcff01c",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multithreaded/listener_test.cpp"
    },
    {
      "type": "modify",
      "old_id": "3b8e909cef434ef4af0f6ba986a2cf57b7aa3904",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multithreaded/test_breakpoint_callback.cpp",
      "new_id": "5cff1cd2b23b669d1037d64b1f3c930ecca41882",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multithreaded/test_breakpoint_callback.cpp"
    },
    {
      "type": "modify",
      "old_id": "eea3b9ed65f2414be4daff334cb4fe7ce4a6dd72",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multithreaded/test_breakpoint_location_callback.cpp",
      "new_id": "2a5d9c427089727c55f87874665f0166cbb69918",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multithreaded/test_breakpoint_location_callback.cpp"
    },
    {
      "type": "modify",
      "old_id": "a88892340e61381c8023484d219ecf3d584a7b55",
      "old_mode": 33188,
      "old_path": "lldb/test/API/api/multithreaded/test_stop-hook.cpp",
      "new_id": "9c754d131214d3a018d31cc9327c8adb536e3eb4",
      "new_mode": 33188,
      "new_path": "lldb/test/API/api/multithreaded/test_stop-hook.cpp"
    }
  ]
}
