x86: fix musttail sibcall miscompilation (#168956) fixes https://github.com/llvm/llvm-project/issues/56891 fixes https://github.com/llvm/llvm-project/issues/72390 fixes https://github.com/llvm/llvm-project/issues/147813 Currently the x86 backend miscompiles straightforward tail calls when the stack is used for argument passing. This program segfaults on any optimization level: https://godbolt.org/z/5xr99jr4v ```c typedef struct { uint64_t x; uint64_t y; uint64_t z; } S; __attribute__((noinline)) uint64_t callee(S s) { return s.x + s.y + s.z; } __attribute__((noinline)) uint64_t caller(S s) { [[clang::musttail]] return callee(s); } ``` The immediate issue is that `caller` decides to shuffle values around on the stack, and in the process writes to `*rsp`, which contains the return address. With the return address trashed, the `ret` in `callee` jumps to an invalid address. ```asm caller: mov rax, qword ptr [rsp + 24] mov qword ptr [rsp + 16], rax movaps xmm0, xmmword ptr [rsp + 8] movups xmmword ptr [rsp], xmm0 ; <-- that is just all kinds of wrong movaps xmmword ptr [rsp + 8], xmm0 mov qword ptr [rsp + 24], rax jmp callee ``` However, I think the actual problem is that the x86 backend never considers `musttail` calls to be sibcalls. For sibcalls, no stack reshuffling is required at all, circumventing the problem here. This PR essentially copies https://reviews.llvm.org/D131034 (cc @huangjd), but this time I hope we can actually land this, and solve this problem. The aarch64 backend also miscompiled this example, but they appear to have fixed it in LLVM 20. Tail calls just not working for any sort of non-trivial argument types is a blocker for tail call support in rust, see https://github.com/rust-lang/rust/issues/144855#issuecomment-3536643185.
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.