tree 076be76b230271def1a71dab9e9cff02ab837070
parent c4bc1b1d8177961c50c7a197bfb97b5226e749ff
author Joseph Huber <huberjn@outlook.com> 1743165316 -0500
committer GitHub <noreply@github.com> 1743165316 -0500
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJn5peECRC1aQ7uu5UhlAAA2GkQAHNkfpbr9U5UW/z8w3OakXCj
 5ac376kFBTf+IQVnPEUqfmz4KnDKCaFZrg+5VCIDhSl4rWqDchTNijiNnLTJ4/ZU
 sCkbhGsvsFV2iESJQ01P/r/ZA/G7RePBxCLPH79xtjiKiwKmAJ5+w0MLIV7ICa2Z
 zPmZcMW/EfK/NZLP1qoggViGcAh3++QzNGOTSY2hKINYjOpoIXtb62MjzUTl/Umn
 xZ9wQJtBxyFb17yobZP+qtfseB51Uq0GT99Boho1uxizsKsz20nkPoe1Ah1iN3nb
 +SFvHvuzUo/CoIWAFl8DUz6R6JSCCoZSaK31PSST3KsIKXc/Ry6svNsBEU5Ueh8C
 CO4K9AxdBmtXYzsd7xVub4dGB7JcQQmchE44qv7ZBXiQUU62gpWJ6B+9S4J4M4qg
 Ai82E1TM8vRIfr7j6KWLsXmhYHRKEY1WSAar3YTdff54p3vkMrQ/MFtmp7vRPD8S
 8YuDyd0UDwOg7GFE3wRpPhG1QpnudWQqrxeSZ072RoHo6ipS/VnZ0I3sHvRYcqir
 4IBhfDbYF0mCJlbDCDFbsr0+VXvKilCpKxXW7GfsPrpgc+5hfuildSwQs3pllJSt
 dFNhqI3znmotG3Li4vE3Lh6Z4saIzcHHuEsiPRQgFW1rmfnRa+QYuHNPJjT9fvLb
 TuKi5FL+xmnI37wWbRyB
 =bBbA
 -----END PGP SIGNATURE-----
 

[Clang][AMDGPU] Remove special handling for COV4 libraries (#132870)

Summary:
When we were first porting to COV5, this lead to some ABI issues due to
a change in how we looked up the work group size. Bitcode libraries
relied on the builtins to emit code, but this was changed between
versions. This prevented the bitcode libraries, like OpenMP or libc,
from being used for both COV4 and COV5. The solution was to have this
'none' functionality which effectively emitted code that branched off of
a global to resolve to either version.

This isn't a great solution because it forced every TU to have this
variable in it. The patch in
https://github.com/llvm/llvm-project/pull/131033 removed support for
COV4 from OpenMP, which was the only consumer of this functionality.
Other users like HIP and OpenCL did not use this because they linked the
ROCm Device Library directly which has its own handling (The name was
borrowed from it after all).

So, now that we don't need to worry about backward compatibility with
COV4, we can remove this special handling. Users can still emit COV4
code, this simply removes the special handling used to make the OpenMP
device runtime bitcode version agnostic.