[MLIR] Fix AsmPrinter alias uniqueness check (#172734) A sneaky operator precedence bug caused this resize operation to always truncate to size 0 or 1: ``` probeAlias.resize(alias.size() + isdigit(alias.back()) ? 1 : 0); ``` Because `+` is associated more strongly than the ternary operator. This eventually led to the asm printer repeating an alias name, generating illegal IR. It wasn't a problem in most cases because it required two things to trigger: - Two naturally generated aliases, one "xxx" the other "xxx1" (note the trailing "1"). - A unique processing order such that we process "xxx", then "xxx1", then "xxx" again. This can only happen if they happen to be at different "alias depths", since otherwise the pre-sorting will make sure this ordering never happens. See the added test case for how this works in practice (I will also attach what the current code generates). This PR fixes the operator precedence, but also moves the calculation outside the loop since it never changes.
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.