tree 79e5fed573676ec95c0ebb06338df7a1bd6bdfcc
parent 6e1aee4276bbd6f84b34ce449a3c88d2013ca5e4
author Vladislav Dzhidzhoev <vdzhidzhoev@accesssoftek.com> 1772652732 +0100
committer GitHub <noreply@github.com> 1772652732 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJpqIi8CRC1aQ7uu5UhlAAA1XgQAIRPiogzq90xxX1FOeOyZGMp
 Ow8MmSxO6AdSNhBG39zCapGSAdLOR2RnOzRQPlknzlOXdUF67VUNg0R06LMfaNX7
 +ijzfnuWT1U5Z+FOaGGs6GHD+rgj3hhDi950eNF93lty5rLuiEzyKdckbTeKontH
 Eq2g2trBIjJH/mpUpx4XhCYfi8hksKpwQ+gGCaEPKDVFAal65wzM89q74wSD7xxV
 AA8rjBF5puVvWE7IX65AdiKscAOI3ZznMhdNHKvK/GbSQF/PNhBIERbvgMWTCxfH
 nYh0M69LxgHjF7RpWvZqUTERMaP094K++lVxPNUAeF15pMFtA+QjM4zIKfGMFPiq
 xWSCv1+CyQMvSmf4O5qDu318E9/BXBjaJvZZa36HERdd2isn0e4f/duvNAl3ZPa4
 ZAI5ixNSr/971nMDaIeoykXst/EOmMFRi9RN069pYvN17byjpgGw/IuVYBkkYIvZ
 L4iXqCjQ/NEF2LRU1G9awMjK74NWakZMUxt/tM0vI+ylIOor56UJ9lGQlvSYxUh3
 XoDPeYwZxJPwhVM4UJIEvat8x+6rZUBrJNQUIuL74ekX302h+SDs7H8ZO+kNZTtX
 9Ko5ttdyjWy4LMt7vS9HkuJe/eNW41Bzv8WFvUzmuRmhaAQHG+AbYs2IqKMWAGGJ
 wAmxwRYNEZz6JW9TI17U
 =V1sE
 -----END PGP SIGNATURE-----
 

[DebugInfo][DwarfDebug] Move emission of globals from beginModule() to endModule() (5/7) (#184219)

RFC
https://discourse.llvm.org/t/rfc-dwarfdebug-fix-and-improve-handling-imported-entities-types-and-static-local-in-subprogram-and-lexical-block-scopes/68544

This patch moves the emission of global variables from
`DwarfDebug::beginModule()` to `DwarfDebug::endModule()`.

It has the following effects:
1. The order of debug entities in the resulting DWARF changes.
2. Currently, if a DISubprogram requires emission of both concrete
out-of-line and inlined subprogram DIEs, and such a subprogram contains
a static local variable, the DIE for the variable is emitted into the
concrete out-of-line subprogram DIE. As a result, the variable is not
available in debugger when breaking at the inlined function instance.

It happens because static locals are emitted in
`DwarfDebug::beginModule()`, but abstract DIEs for functions that are
not completely inlined away are created only later during
`DwarfDebug::endFunctionImpl()` calls.

With this patch, DIEs for static local variables of subprograms that
have both inlined and the concrete out-of-line instances are placed into
abstract subprogram DIEs. They become visible in debugger when breaking
at concrete out-of-line and inlined function instances.

   `llvm/test/DebugInfo/Generic/inlined-static-var.ll` illustrates that.
3. It will allow to simplify abstract subprogram DIEs creation by
reverting https://github.com/llvm/llvm-project/pull/159104 later.

This is needed to simplify DWARF emission in a context of proper support
of function-local static variables which comes in the next patch
(https://reviews.llvm.org/D144008), making all function-local entities
handled in `DwarfDebug::endModuleImpl()`.

Authored-by: Kristina Bessonova <kbessonova@accesssoftek.com>
Co-authored-by: David Blaikie <dblaikie@gmail.com>
Co-authored-by: Vladislav Dzhidzhoev <vdzhidzhoev@accesssoftek.com>