)]}'
{
  "commit": "608f2bfd65ec14debe22bce8179ffe2b514b4e91",
  "tree": "ec643018c6c883a5a18e3f8b879344cfa70fcb20",
  "parents": [
    "dac3ea4eb3f6fc75be4305b9b7ed1a861ea5993e"
  ],
  "author": {
    "name": "Joel E. Denny",
    "email": "jdenny.ornl@gmail.com",
    "time": "Wed Aug 14 02:56:09 2019 +0000"
  },
  "committer": {
    "name": "Joel E. Denny",
    "email": "jdenny.ornl@gmail.com",
    "time": "Wed Aug 14 02:56:09 2019 +0000"
  },
  "message": "[FileCheck] Move -dump-input diagnostic to first line\n\nWithout this patch, `-dump-input` prints a diagnostic at the end of\nits marker range.  For example:\n\n```\n         1: Start.\ncheck:1     ^~~~~~\n         2: Bad.\nnext:2      X~~~\n         3: Many lines\nnext:2      ~~~~~~~~~~\n         4: of input.\nnext:2      ~~~~~~~~~\n         5: End.\nnext:2      ~~~~ error: no match found\n```\n\nThis patch moves it to the beginning like this:\n\n```\n         1: Start.\ncheck:1     ^~~~~~\n         2: Bad.\nnext:2      X~~~ error: no match found\n         3: Many lines\nnext:2      ~~~~~~~~~~\n         4: of input.\nnext:2      ~~~~~~~~~\n         5: End.\nnext:2      ~~~~\n```\n\nThe former somehow looks nicer because the diagnostic doesn\u0027t appear\nto be somewhere within the marker range.  However, the latter is more\npractical, especially when the marker range includes the remainder of\na very long dump.  First, in the case of an error, this patch enables\nme to search the dump for `error:` and usually immediately land where\nthe detected error began.  Second, when trying to follow FileCheck\u0027s\nlogic, it\u0027s best to read top down, so this patch enables me to see\neach diagnostic as soon as I encounter its marker.\n\nReviewed By: thopre\n\nDifferential Revision: https://reviews.llvm.org/D65702\n\nllvm-svn: 368786\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b7bb8db5223cb021fff0f19c20d565893c4ff1c6",
      "old_mode": 33188,
      "old_path": "llvm/test/FileCheck/dump-input-annotations.txt",
      "new_id": "71bd0fb0a67f4cf71c62fdb7b681e4ad0b252438",
      "new_mode": 33188,
      "new_path": "llvm/test/FileCheck/dump-input-annotations.txt"
    },
    {
      "type": "modify",
      "old_id": "d9cad13c465a113c3bf05a9ac0164dd0f0d56db9",
      "old_mode": 33188,
      "old_path": "llvm/utils/FileCheck/FileCheck.cpp",
      "new_id": "879a3834eda4729d5f60466f83be77c20cc476a8",
      "new_mode": 33188,
      "new_path": "llvm/utils/FileCheck/FileCheck.cpp"
    }
  ]
}
