tree e81d0b4d51e9475c948e15de80a0bff65ff07cfe
parent 5047e3a3ba92402b60c200201484b422cad8bea6
author Carlos Galvez <carlosgalvezp@gmail.com> 1637659643 +0000
committer Carlos Galvez <carlosgalvezp@gmail.com> 1638257477 +0000

[clang-tidy] Warn on functional C-style casts

The google-readability-casting check is meant to be on par
with cpplint's readability/casting check, according to the
documentation. However it currently does not diagnose
functional casts, like:

float x = 1.5F;
int y = int(x);

This is detected by cpplint, however, and the guidelines
are clear that such a cast is only allowed when the type
is a class type (constructor call):

> You may use cast formats like `T(x)` only when `T` is a class type.

Therefore, update the clang-tidy check to check this
case.

Differential Revision: https://reviews.llvm.org/D114427