[lld][WebAssembly] Fix use of undefined funcs under --warn-unresolved-symbols (#78643)
When undefined functions exist in the final link we need to create
stub functions (otherwise direct calls to those functions could
not be generated). We were creating those stub when
`--unresolved-symbols=ignore-all` was passed but overlooked the fact
that `--warn-unresolved-symbols` essentially has the same effect (i.e.
undefined function can exist in the final link).
Fixes: #53987
diff --git a/lld/wasm/Relocations.cpp b/lld/wasm/Relocations.cpp
index fcffacb..09b0a24 100644
--- a/lld/wasm/Relocations.cpp
+++ b/lld/wasm/Relocations.cpp
@@ -54,21 +54,22 @@
case UnresolvedPolicy::Ignore:
LLVM_DEBUG(dbgs() << "ignoring undefined symbol: " + toString(*sym) +
"\n");
- if (!config->importUndefined) {
- if (auto *f = dyn_cast<UndefinedFunction>(sym)) {
- if (!f->stubFunction) {
- f->stubFunction = symtab->createUndefinedStub(*f->getSignature());
- f->stubFunction->markLive();
- // Mark the function itself as a stub which prevents it from being
- // assigned a table entry.
- f->isStub = true;
- }
- }
- }
break;
case UnresolvedPolicy::ImportDynamic:
break;
}
+
+ if (auto *f = dyn_cast<UndefinedFunction>(sym)) {
+ if (!f->stubFunction &&
+ config->unresolvedSymbols != UnresolvedPolicy::ImportDynamic &&
+ !config->importUndefined) {
+ f->stubFunction = symtab->createUndefinedStub(*f->getSignature());
+ f->stubFunction->markLive();
+ // Mark the function itself as a stub which prevents it from being
+ // assigned a table entry.
+ f->isStub = true;
+ }
+ }
}
}
