commit 55ff96abfa08ec94b0f8f4ebe187a3232e9d92b7
author weiwei chen <weiwei.chen@modular.com> Sat Apr 05 19:41:52 2025 -0400
committer GitHub <noreply@github.com> Sat Apr 05 19:41:52 2025 -0400
tree eecbaf7a8bb99b2edb95b9e789aa0b6352554e9c
parent 7833107993e7df63301c655e0b4c49b2f625fa5e

[X86][Test] Reorder PassMgrF and OS. (#134481)

Reordering `OS` and `PassMgrF` should fix the asan failure that's caused
by OS being destroyed before `PassMgrF` deletes the AsmPrinter.

As shown in[ this asan run
](https://lab.llvm.org/buildbot/#/builders/52/builds/7340/steps/12/logs/stdio)

```
  This frame has 15 object(s):
    [32, 48) 'PassMgrF' (line 154)
    [64, 1112) 'Buf' (line 155)
    [1248, 1304) 'OS' (line 156) <== Memory access at offset 1280 is inside this variable
```
which indicates an ordering problem. 

This should help to fix all the sanitizer failures caused by the test
`X86MCInstLowerTest.cpp` that's introduced by [this
PR](https://github.com/llvm/llvm-project/pull/133352#issuecomment-2780173791).

llvm/unittests/CodeGen/X86MCInstLowerTest.cpp

diff --git a/llvm/unittests/CodeGen/X86MCInstLowerTest.cpp b/llvm/unittests/CodeGen/X86MCInstLowerTest.cpp
index f5a59b1..72cc79a 100644
--- a/llvm/unittests/CodeGen/X86MCInstLowerTest.cpp
+++ b/llvm/unittests/CodeGen/X86MCInstLowerTest.cpp
@@ -151,9 +151,10 @@
   MachineModuleInfoWrapperPass *MMIWP =
       new MachineModuleInfoWrapperPass(TM.get(), &*MCFoo);
 
-  legacy::PassManager PassMgrF;
   SmallString<1024> Buf;
   llvm::raw_svector_ostream OS(Buf);
+  legacy::PassManager PassMgrF;
+
   AsmPrinter *Printer =
       addPassesToEmitFile(PassMgrF, OS, CodeGenFileType::AssemblyFile, MMIWP);
   PassMgrF.run(*M);