tree 829e520147ba786178300b9c60378150cf73d864
parent bad2036c6ef13e4b44fdea527c3f6ea49033358d
author cmtice <cmtice@google.com> 1756915054 -0700
committer GitHub <noreply@github.com> 1756915054 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJouGVuCRC1aQ7uu5UhlAAAD+8QAARYVMTvCQgWcQ5213hAqKkI
 XB0TpkWL9lOmV6a5C6rwv9lVq7aygt8/JRtPoDgBGcFK9nroal8AtCE0PwRmutR7
 lWpQ3hQ4qaGTmfqlA0BAn+t2tDOPFMhHlZp2i1y1Bwo2UPN92cvqzRKpI34LCYJ/
 CQ/J3cJcWon32j0gwUsC1vqeK8YBC02khjfC2dHXBm6cBpHuKVLeb7i0JK6wCwO4
 rTtKW033kz7v3N2UfgrdzrIwqNxLt9qZEg/NCUyRFT8jYW0qn78Ddn6waKLI5yiG
 h/OTKYRKcdb/590rq0jbbpTERs4MfbKdXC7GDvm6pDI4F2BVGh8pEJkmCA6cWGHj
 gG2hyOW4LGNxQq6lpzMvXU1TIo9buA9vss+SPLfbjLz9xlAbc+PS1oFqXvSDodHu
 Uj81r8X+r5TYHRYDbXx1KE+oiN4OopyNPgyqzvPf/5Y+WgYzP2ja5vzFiH4BZXFa
 OOlJ87qpU97fsv6jKd86JyrVpMBbGv5kP/fH/S/8wp0U+oomgRjxQiaX02posYyM
 HXvS+MjgLqSSRKQO8wSUh1xzhLRAHdjor+9YnLuxCQXpsG+gzeuD8Vwf4XjuhbfF
 80UfAPYZ4Wyw4teFwAbg0v7zXaZjo/EnGZLtuxKklbbSuaPx6HOB8jDdpzgIZZ3i
 581/BMDWkJv3W6LRNZ+E
 =ACXP
 -----END PGP SIGNATURE-----
 

[lit] Update internal shell lexer to handle LLDB persistent vars. (#156125)

LLDB allows creation of 'persistent' variables, with names that start
with '$'. The lit internal shell was escaping the '$', making it '\\$',
in some CHECK lines, which causes an LLDB test,
TestExprWithSideEffectOnConvenienceVar, to fail when using the lit
internal shell.

Further explanation of the failing LLDB test: LLDB convenience variables
start with '$'. The test passes several quoted commands that use and
update convenience variables to lldb as arguments to be run in batch
mode. The tool that packages up the complete string and passes it to the
lit internal shell lexer for lexing inserts a backslash in front of the
'$' before passing the string in for lexing. The lexer was passing this
change along, causing the tests to fail.

This PR fixes the issue by having the lexer remove the newly added
escape on the '$'.