tree 09449fa4934fd895a96d2ffee3d2aa98f8d3ddf3
parent 0eb560a4dee05a55781f44c60c8164aef3bcf04c
author Jeremy Morse <jeremy.morse@sony.com> 1744218028 +0100
committer GitHub <noreply@github.com> 1744218028 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJn9qesCRC1aQ7uu5UhlAAA/OUQACa9KQC7+YSHWSs+Gj6XvVbl
 nV4bxV8GFlWwNFlhot52pq+Uo+bFINLkEmU0MGWKLfcUapyzY20BaIYBDtO6ORmg
 rDCRln/vw8Xmd+wAJBy1t748rxm4nOE3LGXxdRpnJILNiS34ZUZZOwJJGtc3RFZ/
 kZdQ7y/jkb+rcx9LfBqVRg2Mq/JYWZtGEdlYuYVUcQoYjMDGIg81IvmT+lBZlFCi
 s2+LdScdag1k/Hj2ud6CrCewxdskYJv036nM84c4U3PAT+xuqAP8o8oKfvHsJnZ+
 DHLGTinSWTrQOyxu/UFOkCHr1mEgv49ZVuYuTFvtcZVyubhcqnT/ZXcTNLpmtvMN
 nRi4T/mIaIT6CcLr71K4c4vFqOU+c0nBM/cMri3aiCKxDCG1hJeaKm28kcIHDLmF
 O5O5u/xWYcFv8QJcg8t+gZ8I3IW+M8RLcpHKTvzh5LBWr6uwKRF3OT5BUQIzotzB
 q8r5iYMnZeU6ZF2oHvy3zaZ4eq7SpsOf22CCcHwPpFFLIepoiI3loRs9Rj0f1ATH
 g/kuc/B96v6ZOu3KM9k+5SL63DvWVJ/IMRkwfyZAqE+SD2cVagbh87D1XQe7H14A
 9OBPNyUOKOysQ6ZfYvYH86PmXS+mUsmKI1RLcSj2LwqVBwEOVxPIT+j5Jxb4HkgF
 eBiqLIkmMBoTTHzlI7Gm
 =Rr8T
 -----END PGP SIGNATURE-----
 

[DebugInfo][RemoveDIs] Eliminate another debug-info variation flag (#133917)

The "preserve input debug-info format" flag allowed some tooling to opt
into not seeing the new debug records yet, and to not autoupgrade. This
was good at the time, but un-necessary now that we'll be ditching
intrinsics shortly.

It also hides errors now: verify-uselistorder was hardcoding this flag
to on, and as a result it hasn't seen debug records before. Thus, we
missed a uselistorder variation: constant-expressions such as GEPs can
be contained within debug records and completely isolated from the value
hierachy, see the metadata-use-uselistorder.ll test. These Values didn't
get ordered, but were legitimate uses of constants like "i64 0", and we
now run into difficulty handling that. The patch to AsmWriter seeks
Values to order even through debug-info now.

Finally there are a few intrinsics-tests relying on this flag that we
can just delete, such as one in llvm-reduce and another few in the
LocalTest unit tests. For the fast-isel test, it was added in
https://reviews.llvm.org/D67703 explicitly for checking the size of
blocks without debug-info and in 1525abb9c94 the codepath it tests moved
towards being sunsetted. It'll be totally redundant once RemoveDIs is on
permanently.

Note that there's now no explicit test for the textual-IR autoupgrade
path. I submit that we can rely on the thousands of .ll files where
we've only been bothered to update the outputs, not the inputs, to debug
records.