tree 00447c2f7b1d20ddefbf6961038c5dfed6e8e30b
parent 8af8a60d544afaeac4834bb78f6b55bc890fb5fd
author Prerona Chaudhuri <pchaudhuri@nvidia.com> 1777924701 +0530
committer GitHub <noreply@github.com> 1777924701 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJp+PpdCRC1aQ7uu5UhlAAAYxwQAEXcbqYJlyp0zN9LTA8tm3ew
 9YgvShasoOBHrIVE55lcBtQNfHBsvk2EhWVSpziqEWBw1jPwMAJenRZHsMSm4WU8
 BLhS9QEt8wXcs4mBW+ffhW3lzuBnljKL6I0kT6ZLYOGuF382hkaM8l6gNn1BqWuw
 3VM7+pemcA58A+yVa1z5/w075nNR+5qlp/ByfOU49sKhqOxvUk+DHhjtivH/Dq1y
 bQ12vbS/zqD2TNTKccKU1rQQYOI0iyerSjp+aJAk566IcfzIOvHOjnz2ukeufGm9
 unYhon9Ry10rPMgOTSdX0mW8i332+phevjd1pfFErc61KPj+t1gHRU6AO8o9hgYW
 zX5HfMOK5APPcs+bBatdyDNBl/kUL/A3S1oqa1ZXe6IaJ/EYiTQ5hAb9xgFH1MJ9
 Ah1EQ/VIdFaIBFuGBqpZyd2+WGmPmI8/DUEj9B95pw2mI64kW6wPPw1s70LfBjbD
 tc3WowximtiroGs04T1q3LLRUjsBYktjA30rf16Xm+Gsk2QLh67+ZGIGj21mPbLS
 tiRlzyWzAJTq0FWWfgBIgnBpBvEuLLQetS2H95QaX8VCvRfr0XpGG77Qx6XnCMF5
 f8fk8utqk8So0rvX7NKI57it0A5jpCKSvNE2Ovux9B8h9lc7L199Ckke3wUZTuGU
 YhkxDoHKUytE+YEo5teL
 =nNFL
 -----END PGP SIGNATURE-----
 

[TableGen] Fix null-pointer assert in RecordVal::setValue on failed cast (#195492)

When setValue's getCastTo failed, Value was overwritten with nullptr
instead of being left untouched.
The "no value set" sentinel is UnsetInit, not nullptr, so a downstream
RecordResolver::resolve that called isa<UnsetInit>(RV->getValue()) would
assert on the null pointer when a later def tried to resolve an
expression referring to that field.

Compute the cast into a local and only commit to Value on success, so a
type-incompatible override (e.g. redeclaring an int field as string in a
subclass) reports the existing "is incompatible" error and exits cleanly
instead of aborting.

Fixes issue : https://github.com/llvm/llvm-project/issues/184879
Assisted by Claude.