tree 9409e446dc64a8c60641bb5ef734c23e2dc589e0
parent dbb79c30c9f3578b7afd9ea0ec33f82e70e472c7
author cor3ntin <corentinjabot@gmail.com> 1744870195 +0200
committer GitHub <noreply@github.com> 1744870195 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoAJszCRC1aQ7uu5UhlAAAORgQAKynurGN2L7hkQo/InbLjE4z
 O7S6Df+MyK5rHPFUhBBjm/1LUbDl4bWu8FGVqpmImfYmFan4bOPeG/qb8xr2Mv/V
 7Fgfy+HjsNnxs4AD9Ewt02bLhTZ/ayjrGL8Uem8xTADumHI8N6TBdaVBgFCAi6V4
 /ehmdvLKwezfIuftvoFuYRmB4APutqh+l2fvT0RQ2rSdXAmyeJxDXY0lwNl6a4u7
 RzK6TLMvg88P8lA3l8ucMs1j8C4q75NT0Uy1rGcWljzadY2zl/Uwozt93m5b2RNe
 AfAdZdVF9T3MeD5aKzugKq5gNz0lvzRSEqcxkntFHDdsFPEoYczu1dPVNEQXctU3
 7MlozmcIskjwYYw8pJNcjSSirB9FIHXmSKoMfVzhLeLiFOb8aqXKLtlGsRMZ3fcw
 2qP59Qr+Ubs//NMs52UgJFqIs6CTDnYKnjsjo8K3cSCf6oYMUm76oSZk0NvcIuvH
 E9BYeMOsmHQMMkP0J0fn5y74OTNJ4TXctmSloYQrLm7lf9Gul7k+6kHCii3Chrwi
 U3Km+vYbk5xdmZMb83CmGyIQAOXx+tFgCAJkqeVl/MjKTfj4cgW3kr2awcuu8flx
 KUN/Y0hVq4gAApT7ZUtWaAHM5Xf35Zw9tD0gCsYrDWTdr6Fjkdzu0t0QiNG6Qx7q
 J/czmTeFEw3nH1frc/0M
 =DHfq
 -----END PGP SIGNATURE-----
 

[Clang] Bypass TAD during overload resolution if a perfect match exists (#136018)

This implements the same overload resolution behavior as GCC,
as described in https://wg21.link/p3606 (section 1-2, not 3)

If during overload resolution, there is a non-template candidate
that would be always be picked - because each of the argument
is a perfect match (ie the source and target types are the same),
we do not perform deduction for any template candidate
that might exists.

The goal is to be able to merge
https://github.com/llvm/llvm-project/pull/122423 without being too
disruptive.

This change means that the selection of the best viable candidate and
template argument deduction become interleaved.

To avoid rewriting half of Clang we store in `OverloadCandidateSet`
enough information to be able to deduce template candidates from
`OverloadCandidateSet::BestViableFunction`. Which means
the lifetime of any object used by template argument must outlive
a call to `Add*Template*Candidate`.

This two phase resolution is not performed for some initialization
as there are cases where template candidate are better match
in these cases per the standard. It's also bypassed for code completion.

The change has a nice impact on compile times

https://llvm-compile-time-tracker.com/compare.php?from=719b029c16eeb1035da522fd641dfcc4cee6be74&to=bf7041045c9408490c395230047c5461de72fc39&stat=instructions%3Au

Fixes https://github.com/llvm/llvm-project/issues/62096
Fixes https://github.com/llvm/llvm-project/issues/74581

Reapplies #133426