commit 375c5e2353ed5e5565dfbe43324b320e51bcac79
author Rui Ueyama <ruiu@google.com> Tue Feb 10 18:55:39 2015 +0000
committer Rui Ueyama <ruiu@google.com> Tue Feb 10 18:55:39 2015 +0000
tree 6e5df71e2b6f5c15554c45286d282f894ff798d8
parent 054c50bf4f50b5b93b1543db771715d399d97a74

GNU: Use StringRef::empty instead of a boolean flag.

This local variable name did not follow the style guide,
and it is not actually needed.

llvm-svn: 228722

lld/lib/Driver/GnuLdDriver.cpp

diff --git a/lld/lib/Driver/GnuLdDriver.cpp b/lld/lib/Driver/GnuLdDriver.cpp
index 43474a2..32a5db2 100644
--- a/lld/lib/Driver/GnuLdDriver.cpp
+++ b/lld/lib/Driver/GnuLdDriver.cpp
@@ -393,12 +393,8 @@
 
   std::stack<int> groupStack;
   int numfiles = 0;
-
   bool asNeeded = false;
   bool wholeArchive = false;
-
-  bool _outputOptionSet = false;
-
   bool hasNoStdLib = false;
 
   // Ignore unknown arguments.
@@ -513,7 +509,6 @@
       break;
 
     case OPT_output:
-      _outputOptionSet = true;
       ctx->setOutputPath(inputArg->getValue());
       break;
 
@@ -723,9 +718,8 @@
     return false;
   }
 
-  // Set default output file name if the output file was not
-  // specified.
-  if (!_outputOptionSet) {
+  // Set default output file name if the output file was not specified.
+  if (ctx->outputPath().empty()) {
     switch (ctx->outputFileType()) {
     case LinkingContext::OutputFileType::YAML:
       ctx->setOutputPath("-");

lld/unittests/DriverTests/GnuLdDriverTest.cpp

diff --git a/lld/unittests/DriverTests/GnuLdDriverTest.cpp b/lld/unittests/DriverTests/GnuLdDriverTest.cpp
index 5e40b4b..1199136 100644
--- a/lld/unittests/DriverTests/GnuLdDriverTest.cpp
+++ b/lld/unittests/DriverTests/GnuLdDriverTest.cpp
@@ -62,6 +62,11 @@
   EXPECT_EQ("foo", _context->outputPath());
 }
 
+TEST_F(GnuLdParserTest, OutputDefault) {
+  EXPECT_TRUE(parse("ld", "abc.o", nullptr));
+  EXPECT_EQ("a.out", _context->outputPath());
+}
+
 // --noinhibit-exec
 
 TEST_F(GnuLdParserTest, NoinhibitExec) {