| commit | 3408f7b42f7af7c38d8054067c7dcad82df99b2f | [log] [tgz] |
|---|---|---|
| author | Paschalis Mpeis <paschalis.mpeis@arm.com> | Tue Jul 22 09:04:00 2025 +0300 |
| committer | GitHub <noreply@github.com> | Tue Jul 22 09:04:00 2025 +0300 |
| tree | b728df12950564e7c12385511c2028e239266ea4 | |
| parent | 03a170837e78e56e1876c681a4bf95957adc73fd [diff] |
[BOLT] Guard llvm-bolt-wrapper logic of NFC-Mode behind a flag (#146209) Buildbot (`BOLTBuilder`) no longer relies on a wrapper script to run tests. This patch guards the wrapper logic under a flag that is disabled by default. This it allows to: - Eliminate the need for special handling in some tests. - Fix the issue of a wrapper loop (described below) - Simplify the NFC-Mode setup. **Background:** Previously, tests ran unconditionally, which also compiled any missing utilities and the unit tests. The `nfc-check-setup.py` created: - `llvm-bolt.new`, renamed from the current compilation - `llvm-bolt.old`, built from the previous SHA - `llvm-bolt`: a python wrapper pointing to `llvm-bolt.new` Current behaviour and wrapper issue: As before, the old/new binaries identify whether a patch affects BOLT. If so, `ninja check-bolt` builds missing dependencies and run tests, overwriting the `llvm-bolt` wrapper with a binary. However, if Ninja reports: ``` ninja: no work to do. ``` the wrapper remains in place. If the next commit also does no work, `nfc-check-setup.py` renames the existing wrapper to `llvm-bolt.new`, causing an infinite loop. Allowing to disable the wrapper logic prevents this scenario and simplifies the flow. **Test plan:** Creates llvm-bolt.new and llvm-bolt.old and stays on previous revision: ``` ./nfc-check-setup.py build ``` Creates llvm-bolt.new and llvm-bolt.old and returns on current revision: ``` ./nfc-check-setup.py build --switch-back ``` Creates llvm-bolt.new and llvm-bolt.old, returns on current revision, and creates a wrapper: ``` ./nfc-check-setup.py build --switch-back --create-wrapper ``` Creates llvm-bolt.new and llvm-bolt.old, and passes an invalid argument to the wrapper: ``` ./nfc-check-setup.py build --switch-back --create-wrapper --random-arg ```
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.