tree 8b04256bec5b64b9d74df23bbd494432ffc2ecaa
parent 9d5d715330821b8dc1c2880a8d6356a7829eef64
author Donát Nagy <donat.nagy@ericsson.com> 1747241270 +0200
committer GitHub <noreply@github.com> 1747241270 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoJMk2CRC1aQ7uu5UhlAAAjB0QADAuQ/4Y53PFl0sdMnnazKte
 mm3GJljac5yOeku15pc7SLjBq3e4dTVP0ZPfH87SGeilmc24i59v+CBXd5uZwbeL
 l9zQNpRIJlTnxziTkpaSKVilZ6rYtA5H25Lo+y28VFLXAnjXGthrHm+RF15ohuvp
 YXcM6o1cNRBjhBRPagej6yE3ALCa2o/svqZd8OQh9xyxi1IHlhACaeUgvyPsohIm
 Ou547N+H42m6nYBGPOXPRizpZAWy7OM5iANXHgES5zH6uATK297WJAmwdMoDK5ps
 5A+rnU+P6iqbhDh4gEPBhFIshP8IseNQODR4afwXFnVaqjUj4UvdtegzVheTOppo
 MSt8x3ywZoVpzVmlU2Lz8DF867GajKT95szovb6ImNN38kyPlg3EuieJieV5G96w
 s6+hgABTHgyWH+/1MjWyBPjtO/xzrKLiVLV9rS2lw3olwvDMBIfcLBKaGcyEUk6Z
 eGhlQtV911ZcwXxWWY/XKg1SRb3XQnasmAaS6o8v/ByVluY3Lex6q4EcQdsFwhsL
 yAQYFhSuAq8kEuVJtjNHQRv8kselXeesdm0AjpIQ5wKC4gnbzLKtCS+Q3kGhXFDN
 rVcFzAvidXIYWOIQQegYdUN7QMrcUj9hfDB/8tyMZ0sBtgyZgft8XRcsEUzriV3J
 871P4k8XLAB8cHIWtrZt
 =iQWE
 -----END PGP SIGNATURE-----
 

[NFC][analyzer] Clarify that ExplodedGraph has only one root (#139903)

Previously the class `ExplodedGraph` had a data member called `Roots`
which could (in theory) store multiple root nodes -- but in practice
exploded graphs always had at most one root node (zero was possible for
empty and partially copied graphs) and introducing a graph with multiple
roots would've caused severe malfuncitons (e.g. in code that used the
pattern `*roots_begin()` to refer to _the_ root node).

I don't see any practical use case for adding multiple root nodes in a
single graph (this seems to be yet another of the "generalize for the
sake of generalization" decisions which were common in the early history
of the analyzer), so this commit replaces the vector `Roots` with
`ExplodedNode *Root` (which may be null when the graph is empty or under
construction).

Note that the complicated logic of `ExplodedGraph::trim` deserves a
through cleanup, but I left that for a follow-up commit.