[clang-repl] Stop interpreter init on action failure (#217147) `clang::Interpreter` previously ignored the result of its initial `CompilerInstance::ExecuteAction()` call and always constructed the `IncrementalParser`. When the initial action failed, the parser could be created from an invalid compiler state. In practice, this failure happens if the incremental PCH included has expired, due to system headers changing. This happens quite regularly, after system updates, and is affecting jank users. To fix this, the `Interpreter` now returns an error immediately when the initial action fails or records a diagnostic error. This allows jank to add a diagnostic consumer to detect PCH-related errors and rebuild the PCH as needed. ---- I used Github copilot to help me diagnose and fix the issue. I have manually reviewed the code, manually executed the test, and have verified that the fix works locally for jank. I understand the change completely.
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.