commit 28d4149ba0c1748f570fecb683fb1fda62bfd974
author Pasquale Riello <pas.riello@gmail.com> Fri Aug 02 14:32:47 2024 +0100
committer GitHub <noreply@github.com> Fri Aug 02 15:32:47 2024 +0200
tree 237305817e365c14254883ba155d665060959a27
parent e7ee21fbc96664cf7736194c0ed922753e338989

[clang][dataflow] Fix casting in `ChromiumCheckModel`. (#101640)

`getDirectCallee()` may return a null pointer if the callee is not a
`FunctionDecl` (for example when using function pointers), this requires
to use `dyn_cast_or_null` instead of `dyn_cast`.

clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp

diff --git a/clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp b/clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp
index 5ac71e1..77d817daf 100644
--- a/clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp
+++ b/clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp
@@ -56,7 +56,8 @@
     return false;
   auto Stmt = CS->getStmt();
   if (const auto *Call = dyn_cast<CallExpr>(Stmt)) {
-    if (const auto *M = dyn_cast<CXXMethodDecl>(Call->getDirectCallee())) {
+    if (const auto *M =
+            dyn_cast_or_null<CXXMethodDecl>(Call->getDirectCallee())) {
       if (isCheckLikeMethod(CheckDecls, *M)) {
         // Mark this branch as unreachable.
         Env.assume(Env.arena().makeLiteral(false));