tree cb897639578aa5a07e69a1830467c450b3d14ee7
parent 41035f4aa8139353a532509e5d4406dbb07446ac
author Pavel Labath <pavel@labath.sk> 1746188414 +0200
committer GitHub <noreply@github.com> 1746188414 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoFLh+CRC1aQ7uu5UhlAAAFqcQAHc5n03khenTAdxjTr7y8r5/
 cbDfiV+JpLtHRovtLl593yTYJ8uFjLh8rM+AL34SCsgnwphIhRlNa7LWW8P1NUGF
 Qz19/n6AiyTrbW/YEYDWyLopGP2aOXdiBGYvraxuG3LI+aVGFxWNBVvmAQsBZPIe
 K+784PzfCosnzclYb5PoFg4S5IYnL6Awfu+bfj+phapLJwlQQbU54K5a3o8Nw+6z
 VyRU/71c0pC8465vHwsfsggib8c+SiPiHIy2SDF6+J2meuqnuMQo6DHfM4wymlei
 3I06m7jx18iWWmgQzwh1BSefbrqMlsLZUuaHgZZHW4dRQltjjMl1XVfpl5jUw2H5
 ITHm31VTgj/XtnfvS8w5kcMYnrAtQm+2oiXRtp1gzf7WH0tXAXEVpGIY5IUYDfLf
 8w6GZ+nvX1j8EOBMken4p22/bMvlFS8xXQN0kLGKaxK2STWHFF37IhesRbbx94Pw
 zHX5pEbMA5d7aKphsVQ/oiRXJpizH3/kz4Q7T2MMQrgQIybJ/VC94x7N0evxgPqY
 k4+6tyXRbug8MjHTAwb/cQVczVDufCRViL1I2r0scKytCZ3a7cKaozCOerZ8Iso3
 Ipj/ez0ahffQ5MwUpaCkI0FqsV3GvCDAjzMbsBxHzALyObd5Ycm07nsCTd/QZLGA
 YQpiBsyPZvw1RDuRPEju
 =YaP9
 -----END PGP SIGNATURE-----
 

[lldb] Fix dynamic type resolution for types parsed from declarations (#137974)

This fixes a regression caused by us starting to parse types from
declarations. The code in TypeSystemClang was assuming that the value
held in ClangASTMetadata was authoritative, but this isn't (and cannot)
be the case when the type is parsed from a forward-declaration.

For the fix, I add a new "don't know" state to ClangASTMetadata, and
make sure DWARFASTParserClang sets it only when it encounters a forward
declaration. In this case, the type system will fall back to completing
the type.

This does mean that we will be completing more types than before, but
I'm hoping this will offset by the fact that we don't search for
definition DIEs eagerly. In particular, I don't expect it to make a
difference in -fstandalone-debug scenarios, since types will nearly
always be present as definitions.

To avoid this cost, we'd need to create some sort of a back channel to
query the DWARFASTParser about the dynamicness of the type without
actually completing it. I'd like to avoid that if it is not necessary.