[pdb] Fix libc++ strict-weak-ordering assertion failures from gsiRecordCmp (#183749) Builds using libc++ hardening was hitting asserts like libc++ Hardening assertion !__comp(*(__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering printf-debugging revealed that symbols like "?ST@@3JA" were not comparing equal with themselves. It turns out the comparison was done with return S1.compare_insensitive(S2.data()); and even when &S1 == &S2, S1 and S2.data() may not refer to identical strings, since data() may not have a null terminator where the StringRef locally ends. This fixes the ordering, simplifies the code, and makes it a little faster :) Fixes: #163755
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.