tree aab6b97ad683d0db379036798a5311e27f679af1
parent 08ff017fb0c9c7c3c91858023ea45149449fbbfc
author Daniel Paoliello <danpao@microsoft.com> 1755273824 -0700
committer GitHub <noreply@github.com> 1755273824 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJon1pgCRC1aQ7uu5UhlAAAQ5cQAIg6VOB3TaWlTmGvAF/BwFnk
 2OYMZ8SsH4HZv8gk8T6UTl4RJbBzRqjZGpHfhJFY31U50ncX9MLk/Vn4s/2zP8Ce
 s1sQ6fycTdfrTnrdeH8DYye2lhA4J9+N5Pyz/2noKS4vEaS+kOhsU0jbgBuk1pg7
 aZsDL3TL0YK/sjv+dn78ppH3ig+l/G/KH1psWDuoM6S/duL9dqzmtLklX5oP7G7o
 Cnc0e3XsT9p6TFuAemv2+iCf+qh6VoTUu6IexpU1Vf9LWWF663nNPfP+yRONwdR9
 WnrLH2S+OmGGa4liCmWNTIb7I4ZMA1/9zNl4QQxIE9zXAZKND2cHJH4IERtVW+8u
 4wA6knlkGW9jaIKi/Gy2Yy/lOst6dqdp2oUo1zk+VS1HdAqOtgPRoxPe+wJtl38m
 14SaabkP+uLGpeNOP/ztw3a7nohkABgSEzzzy13uYZCbRIkF3cdyRImcrMbWTWbV
 7O7veF1FM3amNcXTp658jfxATlIksvBjD0u01LzVzVmEKy1PtUSMGWEjPq6Ws54Z
 zvyr1kKlz09bV5gLQinJmegoEQi326Ml+qJ0LqjImYjt9+mqBgyGq8edMhzgSvFr
 LkIyl8VMgfMQYqbOyLHrvOzxtCVO0TcRT24QMUBxNK9Wva0qN+mQcr2ASxzZRt5C
 qdo9hdmfrVRT3HMxW/LB
 =lxQb
 -----END PGP SIGNATURE-----
 

[win][x64] Allow push/pop for stack alloc when unwind v2 is required (#153621)

While attempting to enable Windows x64 unwind v2, compilation failed
with the following error:

```
fatal error: error in backend: Windows x64 Unwind v2 is required, but LLVM has generated incompatible code in function '<redacted>': Cannot pop registers before the stack allocation has been deallocated
```

I traced this down to an optimization in `X86FrameLowering`:

<https://github.com/llvm/llvm-project/blob/6961139ce9154d03c88b8d46c8742a1eaa569cd9/llvm/lib/Target/X86/X86FrameLowering.cpp#L324-L340>

Technically, using `push`/`pop` to adjust the stack is permitted under
unwind v2: the requirement for a "canonical" epilog is that the stack is
fully adjusted before the registers listed as pushed in the unwind table
are popped. So, as long as the `.seh_unwindv2start` pseudo is after the
pops that adjust the stack, then everything will work correctly.

One other side effect of this change is that the stack is now allowed to
be adjusted across multiple instructions, which would be needed for
extremely large stack frames.