commit 1c8e5e223fdbb7ce2752d9c30b72519b37376d8c
author Stanley Winata <68087699+raikonenfnu@users.noreply.github.com> Sat Apr 26 10:25:06 2025 +0700
committer GitHub <noreply@github.com> Fri Apr 25 20:25:06 2025 -0700
tree e1e1223d57ccdd24ac4f2466b34bd8d58542c2c5
parent 58d60a4df92d57941f6d47d46bd5025fe6298c93

[mlir][gpu] Fix breaking constructor from GPUSubgroupSizeToROCDL (#137439)

This PR addressed a bug from llvm/llvm-project#137360. which was using
GPUSubgroupSizeToROCDL to patterns function that do not have a valid
constructor for it. This is causing compilation error below:

error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base
class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly
deleted

Signed-off-by: Stanley Winata <stanley.winata@amd.com>

mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp

diff --git a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
index 0a6fb64..dd16ec4 100644
--- a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
+++ b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
@@ -455,9 +455,7 @@
   // TODO: Add alignment for workgroup memory
   patterns.add<GPUDynamicSharedMemoryOpLowering>(converter);
 
-  patterns
-      .add<GPUShuffleOpLowering, GPULaneIdOpToROCDL, GPUSubgroupSizeOpToROCDL>(
-          converter);
+  patterns.add<GPUShuffleOpLowering, GPULaneIdOpToROCDL>(converter);
   patterns.add<GPUSubgroupSizeOpToROCDL>(converter, chipset);
 
   populateMathToROCDLConversionPatterns(converter, patterns);