tree b991e540b905f42baebb0e4b0ea1f16b77be7111
parent 96f2ab28fcf010fffc83b7c87707f27bf637fb92
author Björn Pettersson <bjorn.a.pettersson@ericsson.com> 1758143040 +0200
committer GitHub <noreply@github.com> 1758143040 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoyyJACRC1aQ7uu5UhlAAAMf8QAGRMnO7cKWz94VuATvN5dLmd
 CDVBykso0qIdaeIdV1LQKxMjvY/vwubE+af+UGmlz2duBuYAvP6f3cJWNVFB0CCz
 GHVjWDOxrjXoPIdL8X+5X5qQZa6pAJse/1bjd1aebcT3Vh2VrOGEBM2TWDtcx6l0
 gsKppbPn6P5aUwlJvYmsWt75c2V9PDgX+s/hcDPM+V1hG+e0MjGw7yM4GDStm+0+
 0D3Ih1edjIDhJIyvJ4C6TfONhmj7s22D20Atf2vICpihHNviN6ED8F/vOmmES52O
 BDABj0xUbc8oGCAjIky9Qa+/DkjHIuYKua206Be3JitlIKWYJY2WZJRxN23mwYJi
 jyALmp9fOhyilGgDFJ2LI6zBVZMhshTCj85WcWQgX8oXp/49m7g9Mxqi4WQLOhNg
 6N2iV1JSscuOIoQaHuQ6zqvqA9Akd/T1kPxMvP9JcbRudNNIkJquUHOkjBN/wV0Y
 Mnv7jlpbLn7o1ejNjo4NG+P2TYe/B5kk4zS0E1W3pUfN+Sy0eBwoI+G7JJiBeEDQ
 hOVaRxvPb57HDNbeEJCdHjbM5E5/kF1r0fAlhD11XjwgeShcWAfkguDu6TaJC5lV
 dQCO0R7xYtp4VocBbzog2GZN6vj7zmH+1zU4nS3YI689+B3CyovNmoj8FMDId0vj
 UPRF011tisWxuxfoWrvX
 =5b1B
 -----END PGP SIGNATURE-----
 

[SelectionDAG] Deal with POISON for INSERT_VECTOR_ELT/INSERT_SUBVECTOR (#143102)

As reported in https://github.com/llvm/llvm-project/issues/141034
SelectionDAG::getNode had some unexpected
behaviors when trying to create vectors with UNDEF elements. Since
we treat both UNDEF and POISON as undefined (when using isUndef())
we can't just fold away INSERT_VECTOR_ELT/INSERT_SUBVECTOR based on
isUndef(), as that could make the resulting vector more poisonous.

Same kind of bug existed in DAGCombiner::visitINSERT_SUBVECTOR.

Here are some examples:

This fold was done even if vec[idx] was POISON:
  INSERT_VECTOR_ELT vec, UNDEF, idx -> vec

This fold was done even if any of vec[idx..idx+size] was POISON:
  INSERT_SUBVECTOR vec, UNDEF, idx -> vec

This fold was done even if the elements not extracted from vec could
be POISON:
  sub = EXTRACT_SUBVECTOR vec, idx
  INSERT_SUBVECTOR UNDEF, sub, idx -> vec

With this patch we avoid such folds unless we can prove that the
result isn't more poisonous when eliminating the insert.

Fixes https://github.com/llvm/llvm-project/issues/141034