tree 9aa3086c00912cecf5489b14ef4bbba04390a625
parent 7ec342ba16ca97206aa2ddd5b7ec0da063042e03
author Nikita Popov <npopov@redhat.com> 1713422652 +0900
committer GitHub <noreply@github.com> 1713422652 +0900
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmIME8CRC1aQ7uu5UhlAAAkJ8QAI8CoC7uKvzEDrT0zrUZM6Gj
 dAsy8u267J7wY3ofxIIsgtUQrX35a4kr/U6i+sp7UAbBwXmDaFptNBI3qcoX2gx3
 uB8GWUfZXYIrw5zY9S4nGct4l8tffAH7tMteRDyb9qZHqxE+T1y5dvHQqUgGG0rm
 k14Xg0gzfA8VQY7DlhDDr3q0zh9XU41aQ/LEMqV2W4NHsJ5SCYZwWoDjEhPLFA3G
 jcXnYcJsV680G7yv3PcMQlsIpacmMJmVELCQaDqtCfMdljT5pYhjtAsujDfAjm+e
 4glwhHk3FHv1veFi6VoAU4UIfl3soCZbr6UCcO0Nnp02E39brEsObXB4Sfv69VE9
 pbGvEGk9Uo+Y66XzEfllLT91dSbgcz+lQcexcyXyT51/qD15lS+VnKT4tO4g10On
 3lvPwS19LBqJvU/5YZDhUzNUDvP/S8f54+59QMaV6ix60+niWmmGYJBa30CV6a42
 viml6HI2E7bExCiwC23dGI+z7RAhuziEoHxzHsbiAy4JZey0LdsGwwtCOMaDnsXh
 B6XsiMkDy47FiyyhunE7lybiUYxdYzUn7XZxa2CSr5xq4GyMMbS+u5Jpc6MsNsQ+
 S+qMVDjEN8FK6qUfIOyhahloGatsxy7V/a96BDsoc3IbZ+sMEIBnOU81f7t+b2nE
 cE3cOhxhLDCgGZUav7A5
 =7vBI
 -----END PGP SIGNATURE-----
 

[IR][PatternMatch] Only accept poison in getSplatValue() (#89159)

In #88217 a large set of matchers was changed to only accept poison
values in splats, but not undef values. This is because we now use
poison for non-demanded vector elements, and allowing undef can cause
correctness issues.

This patch covers the remaining matchers by changing the AllowUndef
parameter of getSplatValue() to AllowPoison instead. We also carry out
corresponding renames in matchers.

As a followup, we may want to change the default for things like m_APInt
to m_APIntAllowPoison (as this is much less risky when only allowing
poison), but this change doesn't do that.

There is one caveat here: We have a single place
(X86FixupVectorConstants) which does require handling of vector splats
with undefs. This is because this works on backend constant pool
entries, which currently still use undef instead of poison for
non-demanded elements (because SDAG as a whole does not have an explicit
poison representation). As it's just the single use, I've open-coded a
getSplatValueAllowUndef() helper there, to discourage use in any other
places.