)]}' { "commit": "1b41599cf8972abbf0d2ee7595dba78a4b158af0", "tree": "dc73a47a91632a5cd504ee4b9e8781753cb59675", "parents": [ "5fa985e751c8f890fff31e190473aeeb6f7a9fc5" ], "author": { "name": "Jessica Clarke", "email": "jrtc27@jrtc27.com", "time": "Sun May 18 20:09:43 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sun May 18 20:09:43 2025 +0100" }, "message": "[MC][AArch64][ARM][X86] Push target-dependent assembler flags into targets (#139844)\n\nThe .syntax unified directive and .codeX/.code X directives are, other\nthan some simple common printing code, exclusively implemented in the\ntargets themselves. Thus, remove the corresponding MCAF_* flags and\nreimplement the directives solely within the targets. This avoids\nexposing all targets to all other targets\u0027 flags.\n\nSince MCAF_SubsectionsViaSymbols is all that remains, convert it to its\nown function like other directives, simplifying its implementation.\n\nNote that, on X86, we now always need a target streamer when parsing\nassembly, as it\u0027s now used for directives that aren\u0027t COFF-specific. It\nstill does not however need to do anything when producing a non-COFF\nobject file, so this commit does not introduce any new target streamers.\n\nThere is some churn in test output, and corresponding UTC regex changes,\ndue to comments no longer being flushed by these various directives (and\nEmitEOL is not exposed outside MCAsmStreamer.cpp so we couldn\u0027t do so\neven if we wanted to), but that was a bit odd to be doing anyway.\n\nThis is motivated by Morello LLVM, which adds yet another assembler flag\nto distinguish A64 and C64 instruction sets, but did not update every\nswitch and so emits warnings during the build. Rather than fix those\nwarnings it seems better to instead make the problem not exist in the\nfirst place via this change.", "tree_diff": [ { "type": "modify", "old_id": "691988ae1f1dfef718c3cd43184b7d75f8e528d0", "old_mode": 33188, "old_path": "llvm/include/llvm/MC/MCAsmBackend.h", "new_id": "455812c0b10aaab6ae42a0b754ac294ecdb46c26", "new_mode": 33188, "new_path": "llvm/include/llvm/MC/MCAsmBackend.h" }, { "type": "modify", "old_id": "950dc952d0b44abb08c46a29986fa2feb10840f2", "old_mode": 33188, "old_path": "llvm/include/llvm/MC/MCAsmInfo.h", "new_id": "3a31957f2f6be9b4ef3c465b1e4a7b7d288166ae", "new_mode": 33188, "new_path": "llvm/include/llvm/MC/MCAsmInfo.h" }, { "type": "modify", "old_id": "fcab56ff0a740f58b43176dffdb89a0999cebb0a", "old_mode": 33188, "old_path": "llvm/include/llvm/MC/MCDirectives.h", "new_id": "f8b7e05b3719b558475b8e1c4abd63c94da82739", "new_mode": 33188, "new_path": "llvm/include/llvm/MC/MCDirectives.h" }, { "type": "modify", "old_id": "f084268aad1814b290c15bafd5aba0300002819f", "old_mode": 33188, "old_path": "llvm/include/llvm/MC/MCELFStreamer.h", "new_id": "f00b1645347f1fbf39fd72610d2fab144a86e64d", "new_mode": 33188, "new_path": "llvm/include/llvm/MC/MCELFStreamer.h" }, { "type": "modify", "old_id": "beed370858d788ecad62693375f2ca1f61a1a472", "old_mode": 33188, "old_path": "llvm/include/llvm/MC/MCStreamer.h", "new_id": "1f5014843c5da2e12029b2d20f7096e802fdb9f7", "new_mode": 33188, "new_path": "llvm/include/llvm/MC/MCStreamer.h" }, { "type": "modify", "old_id": "02fda9635f1f89d368d1ae4bdb5fa1dee71c27a0", "old_mode": 33188, "old_path": "llvm/include/llvm/MC/MCWasmStreamer.h", "new_id": "1b97e765fdf48af62e4bf11627f9a808daf668da", "new_mode": 33188, "new_path": "llvm/include/llvm/MC/MCWasmStreamer.h" }, { "type": "modify", "old_id": "bc01362b779b5a19fe27814795c15cf72e2947ab", "old_mode": 33188, "old_path": "llvm/include/llvm/MC/MCWinCOFFStreamer.h", "new_id": "b474ececb21d610d770db1dc18b3245cfe1b5700", "new_mode": 33188, "new_path": "llvm/include/llvm/MC/MCWinCOFFStreamer.h" }, { "type": "modify", "old_id": "49e8db209102b16e1de0b064ae9cec42a86f0876", "old_mode": 33188, "old_path": "llvm/lib/MC/MCAsmInfo.cpp", "new_id": "86759c32bb752294750bbe33e7733c42ae69065d", "new_mode": 33188, "new_path": "llvm/lib/MC/MCAsmInfo.cpp" }, { "type": "modify", "old_id": "42e62459d973082bed9a11ad9d4112372c051426", "old_mode": 33188, "old_path": "llvm/lib/MC/MCAsmStreamer.cpp", "new_id": "f670335045cb10724a95531433e5734c03517051", "new_mode": 33188, "new_path": "llvm/lib/MC/MCAsmStreamer.cpp" }, { "type": "modify", "old_id": "5cf67f018b452ff0432a6cd20a97b9d95f291e9a", "old_mode": 33188, "old_path": "llvm/lib/MC/MCELFStreamer.cpp", "new_id": "7006ac9dda7c2b500855e13396b715f879cc818f", "new_mode": 33188, "new_path": "llvm/lib/MC/MCELFStreamer.cpp" }, { "type": "modify", "old_id": "9b7152f56117509ff67242cd1b05e9c88c74dc03", "old_mode": 33188, "old_path": "llvm/lib/MC/MCMachOStreamer.cpp", "new_id": "4cf602b7e4563f16ecbb5eaff216afb8842b0e3d", "new_mode": 33188, "new_path": "llvm/lib/MC/MCMachOStreamer.cpp" }, { "type": "modify", "old_id": "e84830eb20a729f376c3cb8f627ce09ca90d5ca1", "old_mode": 33188, "old_path": "llvm/lib/MC/MCNullStreamer.cpp", "new_id": "f76b2f754b189da0fbb1631d54b6dfdc376f8710", "new_mode": 33188, "new_path": "llvm/lib/MC/MCNullStreamer.cpp" }, { "type": "modify", "old_id": "5dc9cb64c46ae6468773d82ae75c7f328e04bdd2", "old_mode": 33188, "old_path": "llvm/lib/MC/MCParser/DarwinAsmParser.cpp", "new_id": "de134e25e842fc5dfede8eaebef6f9e417f92b13", "new_mode": 33188, "new_path": "llvm/lib/MC/MCParser/DarwinAsmParser.cpp" }, { "type": "modify", "old_id": "a1968423a12500e3f5cfdc1d1eb3b4c1e734d073", "old_mode": 33188, "old_path": "llvm/lib/MC/MCStreamer.cpp", "new_id": "618a35b9596aa7735b2901b45bff0378bd9bd77e", "new_mode": 33188, "new_path": "llvm/lib/MC/MCStreamer.cpp" }, { "type": "modify", "old_id": "cddd250cc0005164a7c6a8f79fc65acdb27023a3", "old_mode": 33188, "old_path": "llvm/lib/MC/MCWasmStreamer.cpp", "new_id": "9920ff9106fcac0dcb861e14ac18b2b9d4edd01c", "new_mode": 33188, "new_path": "llvm/lib/MC/MCWasmStreamer.cpp" }, { "type": "modify", "old_id": "e03f7b5b6d418613af42974434c96b610128e821", "old_mode": 33188, "old_path": "llvm/lib/MC/MCWinCOFFStreamer.cpp", "new_id": "ee7a7c87eb22fdfa3fe61e918c2fb44375cb7af8", "new_mode": 33188, "new_path": "llvm/lib/MC/MCWinCOFFStreamer.cpp" }, { "type": "modify", "old_id": "d9ef27c790168396f0c7fd81165c1cde749f4deb", "old_mode": 33188, "old_path": "llvm/lib/Object/RecordStreamer.h", "new_id": "edb6e3ae118bf38c3304fb73ab1c50c94da74068", "new_mode": 33188, "new_path": "llvm/lib/Object/RecordStreamer.h" }, { "type": "modify", "old_id": "f55b7ef7c20bbd60f0dbb40f61cae811bf394c6a", "old_mode": 33188, "old_path": "llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp", "new_id": "e9ccc35f346128031babbd62e8b57e554f1cf217", "new_mode": 33188, "new_path": "llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp" }, { "type": "modify", "old_id": "83daa836e650da6631427dab1156e7d9bf7ebd35", "old_mode": 33188, "old_path": "llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp", "new_id": "e8a88f7f31401ffffeafbcf6bf6faeecde642c48", "new_mode": 33188, "new_path": "llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp" }, { "type": "modify", "old_id": "2505a67727aada6369f623eb542bcc80e395d9f5", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/ARMAsmPrinter.cpp", "new_id": "13efd70c0f22b85a4a5133292260e2e0f7b44204", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/ARMAsmPrinter.cpp" }, { "type": "modify", "old_id": "48ad8a8994ae8a5af11734a1ddbab7c5a2cc205b", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp", "new_id": "85b107c6085d31a63c07d1201e4cd7ce8a698aa4", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp" }, { "type": "modify", "old_id": "266ae1ff84e64241d78c89ebc08841906f2a0a76", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp", "new_id": "9b0aafe620c738b159acb43a9cd19a3b511f6c13", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp" }, { "type": "modify", "old_id": "bcf044b340da753eda1ea3da5232d51effd38e3d", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.h", "new_id": "4f017d82aa54113b291ddf66fef0bfcf3aa9da3f", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.h" }, { "type": "modify", "old_id": "9c958003ca756a5ab856993d1545ab6ff4939a33", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendDarwin.h", "new_id": "29cbc40f844a68d0f1c80d0cb971bcd712a08209", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendDarwin.h" }, { "type": "modify", "old_id": "17ae262c0826a4d06193c954a2d77c16e1ef944c", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendELF.h", "new_id": "d0b598dbdc9be7b4adf076e6366b758dd6b70a6e", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendELF.h" }, { "type": "modify", "old_id": "9b50fb7f075821991c3840a83438bd5cd4a53090", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendWinCOFF.h", "new_id": "8a1137e13283cfadf9578f6b85b69a23af6fcb0e", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendWinCOFF.h" }, { "type": "modify", "old_id": "3d45ecf72cc7392c99df22317d511e675228373e", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp", "new_id": "83183970a422d8140d0bedd604d3849cb480e284", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp" }, { "type": "modify", "old_id": "789f7ec09d75980b0b507240b9e936667d17d794", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp", "new_id": "92121dd5704d86bb579daa940dee95c5ddeb3ed0", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp" }, { "type": "modify", "old_id": "632dbebf58f04ca3dcd3d5296a8288c6bb9bac23", "old_mode": 33188, "old_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMTargetStreamer.cpp", "new_id": "130b6a6ba143242cfb38af22803d3e3abcdc4ff0", "new_mode": 33188, "new_path": "llvm/lib/Target/ARM/MCTargetDesc/ARMTargetStreamer.cpp" }, { "type": "modify", "old_id": "11193304a785d2d05e601f8c264aebf667138fdd", "old_mode": 33188, "old_path": "llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp", "new_id": "300f7954369373a1de34edb897ab2d9cf759da95", "new_mode": 33188, "new_path": "llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp" }, { "type": "modify", "old_id": "8cfd9388063a23d126e6b3fa6ecfd0b700839a06", "old_mode": 33188, "old_path": "llvm/lib/Target/X86/MCTargetDesc/X86TargetStreamer.h", "new_id": "486795ff7f4091b64b8a61761128ba21ba511ee9", "new_mode": 33188, "new_path": "llvm/lib/Target/X86/MCTargetDesc/X86TargetStreamer.h" }, { "type": "modify", "old_id": "0d0b43f03d41b20c2355a776b53210ef0c1c5ecf", "old_mode": 33188, "old_path": "llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFTargetStreamer.cpp", "new_id": "16e878d948cf4dc04d1bcce9fb681f9a3e8c6948", "new_mode": 33188, "new_path": "llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFTargetStreamer.cpp" }, { "type": "modify", "old_id": "ce9a7c42d963cb57334db153b74fef908abf518b", "old_mode": 33188, "old_path": "llvm/lib/Target/X86/X86AsmPrinter.cpp", "new_id": "247b792d16ba26b4a37a42552066399a8aa1810d", "new_mode": 33188, "new_path": "llvm/lib/Target/X86/X86AsmPrinter.cpp" }, { "type": "modify", "old_id": "3cf10f0e64b4d11510a927b797d2c7d9606c6a21", "old_mode": 33188, "old_path": "llvm/test/CodeGen/ARM/ldrd.ll", "new_id": "084abc433a47404d340c58185fcb0aa4e3f5bf88", "new_mode": 33188, "new_path": "llvm/test/CodeGen/ARM/ldrd.ll" }, { "type": "modify", "old_id": "beb0d839c8d89534a76c43c766fddcf560d27499", "old_mode": 33188, "old_path": "llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll", "new_id": "0cf1c62e3d8ce3df6bd1762d4e17d7b1a1931360", "new_mode": 33188, "new_path": "llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll" }, { "type": "modify", "old_id": "c52a54569b3dd4083a7d93661957312ceb624d2c", "old_mode": 33188, "old_path": "llvm/test/CodeGen/Thumb/thumb-shrink-wrapping.ll", "new_id": "27720a4200b11a3667102ba49965f72b2342fa77", "new_mode": 33188, "new_path": "llvm/test/CodeGen/Thumb/thumb-shrink-wrapping.ll" }, { "type": "modify", "old_id": "7582f340331593f8a710b5fb1563e64ed6def473", "old_mode": 33188, "old_path": "llvm/test/DebugInfo/ARM/header.ll", "new_id": "6956d47c02129bf5b1338645365c2cc401796f51", "new_mode": 33188, "new_path": "llvm/test/DebugInfo/ARM/header.ll" }, { "type": "modify", "old_id": "7d4fb7d8e150452f85712af37771325a3ef25392", "old_mode": 33188, "old_path": "llvm/utils/UpdateTestChecks/asm.py", "new_id": "da7e7ecc24bdcfed8c7d87974a76a2311033dc20", "new_mode": 33188, "new_path": "llvm/utils/UpdateTestChecks/asm.py" } ] }