commit 19b25a45243948d0d55e0b42d82bb7705c775b77
author Kazu Hirata <kazu@google.com> Fri Mar 14 07:22:44 2025 -0700
committer GitHub <noreply@github.com> Fri Mar 14 07:22:44 2025 -0700
tree 992f5b940079c54bba08bd17eccfd24fc2c42060
parent 1b42be6fe8b850703e0f8e807234e3cb3332ebe0

[dsymutil] Avoid repeated hash lookups (NFC) (#131268)

llvm/tools/dsymutil/BinaryHolder.cpp

diff --git a/llvm/tools/dsymutil/BinaryHolder.cpp b/llvm/tools/dsymutil/BinaryHolder.cpp
index 9429afe..58751bd 100644
--- a/llvm/tools/dsymutil/BinaryHolder.cpp
+++ b/llvm/tools/dsymutil/BinaryHolder.cpp
@@ -242,9 +242,9 @@
     StringRef ArchiveFilename = getArchiveAndObjectName(Filename).first;
     std::lock_guard<std::mutex> Lock(ArchiveCacheMutex);
     ArchiveRefCounter[ArchiveFilename]++;
-    if (ArchiveCache.count(ArchiveFilename)) {
-      return ArchiveCache[ArchiveFilename]->getObjectEntry(Filename, Timestamp,
-                                                           Opts);
+    if (auto It = ArchiveCache.find(ArchiveFilename);
+        It != ArchiveCache.end()) {
+      return It->second->getObjectEntry(Filename, Timestamp, Opts);
     } else {
       auto AE = std::make_unique<ArchiveEntry>();
       auto Err = AE->load(VFS, Filename, Timestamp, Opts);
@@ -252,9 +252,9 @@
         // Don't return the error here: maybe the file wasn't an archive.
         llvm::consumeError(std::move(Err));
       } else {
-        ArchiveCache[ArchiveFilename] = std::move(AE);
-        return ArchiveCache[ArchiveFilename]->getObjectEntry(Filename,
-                                                             Timestamp, Opts);
+        auto &Cache = ArchiveCache[ArchiveFilename];
+        Cache = std::move(AE);
+        return Cache->getObjectEntry(Filename, Timestamp, Opts);
       }
     }
   }