)]}'
{
  "commit": "130dccc2c3192d9f49c2e85bcd047ed67a9fa9e1",
  "tree": "b96587d4d5f06e60f3d2150631c5d8cf94dcc58b",
  "parents": [
    "f958a55f66a062b4c005015b691a949deb24e237"
  ],
  "author": {
    "name": "Nikita Taranov",
    "email": "nikita.taranov@clickhouse.com",
    "time": "Wed Jul 29 19:52:36 2026 +0200"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed Jul 29 10:52:36 2026 -0700"
  },
  "message": "[XRay][test] Raise fdr-mode.cpp unwrite threshold to deflake it (#211595)\n\nIt was observed failing on `sanitizer-aarch64-linux` ([build\n40750](https://lab.llvm.org/buildbot/#/builders/51/builds/40750)).\n\nThe failure is in the `UNWRITE` run\n(`XRAY_FDR_OPTIONS\u003d\"func_duration_threshold_us\u003d5000\"`), which asserts\nthat every short function record is \"unwritten\" (rewound) except\narg1-logging records. In the failing output an `fA()` enter/exit pair\nsurvived:\n\n```\n\u003cstdin\u003e:9:  - { func-id: 3, function: \u0027fA()\u0027, cpu: 0, thread: 1909237, kind: function-enter, tsc: 1784775492023431847 }\n\u003cstdin\u003e:10: - { func-id: 3, function: \u0027fA()\u0027, cpu: 0, thread: 1909237, kind: function-exit,  tsc: 1784775492029462345 }\n\u003cstdin\u003e:11: - { func-id: 4, function: \u0027fArg(int)\u0027, args: [ 1 ], ..., kind: function-enter-arg, ... }\n```\n\nso `UNWRITE-NEXT` (and `UNWRITE-NOT: function-enter`) no longer hold.\n\nFDR mode only rewinds a function\u0027s enter record when its exit lands\nwithin the threshold (`XRayFDRController::functionExit`: `TSC -\nLastFunctionEntryTSC \u003c CycleThreshold`).\n\n```\n1784775492029462345 - 1784775492023431847 \u003d 6,030,498 cycles / 1 GHz \u003d 6.03 ms  \u003e  5 ms threshold\n```\n\ni.e. the thread was preempted for ~6 ms mid-function, so the record was\n(correctly, by the runtime\u0027s own rule) not unwritten.\n\nThe proposed fix is to raise the `UNWRITE` run\u0027s\n`func_duration_threshold_us` from `5000` to `100000`, so realistic\nscheduling jitter cannot push a short function over the threshold. This\nmirrors the accepted fix for the sibling test in\n[PR #186611](https://github.com/llvm/llvm-project/pull/186611)\n(`basic-filtering.cpp`), which flaked the same way.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "08152d3179b17fe1e27851cc719f10f5a4cc3140",
      "old_mode": 33188,
      "old_path": "compiler-rt/test/xray/TestCases/Posix/fdr-mode.cpp",
      "new_id": "1abb765c3a47cf9b3ed9242285f29d481c8d61b5",
      "new_mode": 33188,
      "new_path": "compiler-rt/test/xray/TestCases/Posix/fdr-mode.cpp"
    }
  ]
}
