Google Git
Sign in
llvm / llvm-project / 0e4c482124f098957fc13bcfbabc36775dd190ab
commit0e4c482124f098957fc13bcfbabc36775dd190ab[log] [tgz]
authorAdrian Prantl <aprantl@apple.com>Wed Mar 06 21:22:25 2019 +0000
committerAdrian Prantl <aprantl@apple.com>Wed Mar 06 21:22:25 2019 +0000
tree34ee130b6d6de0d41a229021c4b46ab66b891a08
parent480bce28ffc4640f443e262fa110af50b0d635df [diff]
Pass ConstString by value (NFC)

My apologies for the large patch. With the exception of ConstString.h
itself it was entirely produced by sed.

ConstString has exactly one const char * data member, so passing a
ConstString by reference is not any more efficient than copying it by
value. In both cases a single pointer is passed. But passing it by
value makes it harder to accidentally return the address of a local
object.

(This fixes rdar://problem/48640859 for the Apple folks)

Differential Revision: https://reviews.llvm.org/D59030

llvm-svn: 355553
209 files changed
tree: 34ee130b6d6de0d41a229021c4b46ab66b891a08
  1. clang/
  2. clang-tools-extra/
  3. compiler-rt/
  4. debuginfo-tests/
  5. libclc/
  6. libcxx/
  7. libcxxabi/
  8. libunwind/
  9. lld/
  10. lldb/
  11. llgo/
  12. llvm/
  13. openmp/
  14. parallel-libs/
  15. polly/
  16. pstl/
  17. .arcconfig
  18. .clang-format
  19. .clang-tidy
  20. README.md
README.md

The LLVM Compiler Infrastructure

This directory and its subdirectories contain source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and runtime environments.