[SPIRV] In G_SELECT selection path: replace `removeFromParent` with `eraseFromParent` and return early (#184807) When selecting an `ASSIGN_TYPE` of a `G_SELECT`, both instructions were removed but not erased. The code followed on a code path where the replaced G_SELECT would be added to a remove set if it was dead. But the select is not in the function anymore since it is already removed! Selecting a `selectSelect` always returns `true`. So the assertions/prints below would have never been triggered. This patch simplifies this code path to avoid falling through the asserts and paths where `selectSelect` could have failed (which trivially doesn't happen). Guarded `selectSelect` return with an assert in case it changes. Follow up of https://github.com/llvm/llvm-project/pull/182330
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.