commit 0ccef6a723cbfe3d72b85d34963badb37a6a9a53
author Mats Petersson <mats.petersson@arm.com> Wed Nov 29 16:15:43 2023 +0000
committer GitHub <noreply@github.com> Wed Nov 29 16:15:43 2023 +0000
tree 5facf57d587085aec8f8005ff9f3bdeca2079855
parent 953d675c42c254676ca446951bd728abefecf436

[flang] Make adapt.valuebyref attribute work again (#73658)

This got "lost" in the HLFIR transformation. This patch applies the old
attribute to the AssociateOp that needs it, and forwards it to the
AllocaOp that is generated when lowering to FIR.

flang/lib/Lower/Bridge.cpp

diff --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp
index 23c48cc..0090c2f 100644
--- a/flang/lib/Lower/Bridge.cpp
+++ b/flang/lib/Lower/Bridge.cpp
@@ -2083,10 +2083,10 @@
     assert(sym && "There must be a symbol to bind");
     mlir::Type toTy = genType(*sym);
     // FIXME: this should be a "per iteration" temporary.
-    mlir::Value tmp = builder->createTemporary(
-        loc, toTy, toStringRef(sym->name()),
-        llvm::ArrayRef<mlir::NamedAttribute>{
-            Fortran::lower::getAdaptToByRefAttr(*builder)});
+    mlir::Value tmp =
+        builder->createTemporary(loc, toTy, toStringRef(sym->name()),
+                                 llvm::ArrayRef<mlir::NamedAttribute>{
+                                     fir::getAdaptToByRefAttr(*builder)});
     mlir::Value cast = builder->createConvert(loc, toTy, inducVar);
     builder->create<fir::StoreOp>(loc, cast, tmp);
     addSymbol(*sym, tmp, /*force=*/true);